Fixed memory leak in SetTrustedCertificates in SecurityContext

runtime/bin/security_context.cc

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED) && !defined(DART_IO_SECURE_SOCKET_DISABLED)
 
 #include "bin/security_context.h"
 
 #include <openssl/bio.h>
 #include <openssl/err.h>
@@ skipping 210 matching lines @@
   // file, or that the file isn't PEM. In the first case, status will be
   // non-zero indicating success. In the second case, status will be 0,
   // indicating that we should try to read as PKCS12. If there is some other
   // error, we return it up to the caller.
   return SecureSocketUtils::NoPEMStartLine() ? status : 0;
 }
 
 
 void SSLCertContext::SetTrustedCertificatesBytes(Dart_Handle cert_bytes,
                                                  const char* password) {
-  ScopedMemBIO bio(cert_bytes);
-  int status = SetTrustedCertificatesBytesPEM(context(), bio.bio());
-  if (status == 0) {
-    if (SecureSocketUtils::NoPEMStartLine()) {
+  int status = 0;
+  {
+    ScopedMemBIO bio(cert_bytes);
+    status = SetTrustedCertificatesBytesPEM(context(), bio.bio());
+    if (status == 0) {
+      if (SecureSocketUtils::NoPEMStartLine()) {
+        ERR_clear_error();
+        BIO_reset(bio.bio());
+        status =
+            SetTrustedCertificatesBytesPKCS12(context(), bio.bio(), password);
+      }
+    } else {
+      // The PEM file was successfully parsed.
       ERR_clear_error();
-      BIO_reset(bio.bio());
-      status =
-          SetTrustedCertificatesBytesPKCS12(context(), bio.bio(), password);
     }
-  } else {
-    // The PEM file was successfully parsed.
-    ERR_clear_error();
   }
-
   SecureSocketUtils::CheckStatus(status, "TlsException",
                                  "Failure trusting builtin roots");
 }
 
 
 static int SetClientAuthoritiesPKCS12(SSL_CTX* context,
                                       BIO* bio,
                                       const char* password) {
   ScopedPKCS12 p12(d2i_PKCS12_bio(bio, NULL));
   if (p12.get() == NULL) {
@@ skipping 600 matching lines @@
     Dart_ThrowException(DartUtils::NewDartArgumentError(
         "Non-boolean is_server argument passed to SetAlpnProtocols"));
   }
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED) &&
         // !defined(DART_IO_SECURE_SOCKET_DISABLED)