Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: build/android/update_verification.py

Issue 292313015: [Android] Switch to DeviceUtils versions of Reboot and Install. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/update_verification.py
diff --git a/build/android/update_verification.py b/build/android/update_verification.py
index 91c223be32b425f8fa8249c01a701bb868c8d5aa..fe895670f1302054a40525fb19ac940d29fcb276 100755
--- a/build/android/update_verification.py
+++ b/build/android/update_verification.py
@@ -29,6 +29,7 @@ def _SaveAppData(device, package_name, from_apk=None, data_dir=None):
if from_apk:
logging.info('Installing %s...', from_apk)
+ # TODO(jbudorick) Switch to AdbWrapper.Install on the impl switch.
output = device.old_interface.Install(from_apk, reinstall=True)
if 'Success' not in output:
raise Exception('Unable to install %s. output: %s' % (from_apk, output))
@@ -47,6 +48,7 @@ def _VerifyAppUpdate(device, to_apk, app_data, from_apk=None):
if from_apk:
logging.info('Installing %s...', from_apk)
+ # TODO(jbudorick) Switch to AdbWrapper.Install on the impl switch.
output = device.old_interface.Install(from_apk, reinstall=True)
if 'Success' not in output:
raise Exception('Unable to install %s. output: %s' % (from_apk, output))
@@ -57,6 +59,7 @@ def _VerifyAppUpdate(device, to_apk, app_data, from_apk=None):
logging.info('Verifying that %s cannot be installed side-by-side...',
to_apk)
+ # TODO(jbudorick) Switch to AdbWrapper.Install on the impl switch.
output = device.old_interface.Install(to_apk)
if 'INSTALL_FAILED_ALREADY_EXISTS' not in output:
if 'Success' in output:
@@ -65,6 +68,7 @@ def _VerifyAppUpdate(device, to_apk, app_data, from_apk=None):
raise Exception(output)
logging.info('Verifying that %s can be overinstalled...', to_apk)
+ # TODO(jbudorick) Switch to AdbWrapper.Install on the impl switch.
output = device.old_interface.Install(to_apk, reinstall=True)
if 'Success' not in output:
raise Exception('Unable to install %s.\n output: %s' % (to_apk, output))
« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | tools/telemetry/telemetry/core/backends/adb_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698