[Android] Switch to DeviceUtils versions of Reboot and Install.

[Android] Switch to DeviceUtils versions of Reboot and Install.

BUG=267773
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276702

[frankf, 2014-05-24 00:22:38]

device_utils.py lgtm after fixes

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils.py:160: """ Reboot the device.
no space after quotation mark. Also you didn't fix the onliner docstring from
before :)

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils.py:188: apk_path, device_path,
ignore_filenames=True) > 0):
I'd create a variable to hold len(...) to make this more readable

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
File build/android/pylib/device/device_utils_test.py (right):

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils_test.py:6: Unit tests for the contents
of device_utils.py (mostly DeviceUtils).
You really need unit tests (not necessarily in this CL). This is an end-2-end
test. I'd suggest using mock:

https://pypi.python.org/pypi/mock

[jbudorick, 2014-05-27 20:58:34]

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils.py:160: """ Reboot the device.
On 2014/05/24 00:22:39, frankf wrote:
> no space after quotation mark. Also you didn't fix the onliner docstring from
> before :)

Done wrt no space. There's only one one liner docstring in this file, and it
follows the convention you specified...?

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils.py:188: apk_path, device_path,
ignore_filenames=True) > 0):
On 2014/05/24 00:22:39, frankf wrote:
> I'd create a variable to hold len(...) to make this more readable

Done.

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
File build/android/pylib/device/device_utils_test.py (right):

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils_test.py:6: Unit tests for the contents
of device_utils.py (mostly DeviceUtils).
On 2014/05/24 00:22:39, frankf wrote:
> You really need unit tests (not necessarily in this CL). This is an end-2-end
> test. I'd suggest using mock:
> 
> https://pypi.python.org/pypi/mock

These started as unit tests (see the testInit* tests), but they have admittedly
evolved away from that. I'll look at using mock. It will not be in this CL.

[tonyg, 2014-05-27 21:01:13]

tools/telemetry lgtm

Didn't review the rest.

[frankf, 2014-05-27 21:12:10]

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils.py:160: """ Reboot the device.
Multi-line:

"""Line One.

Line2.
"""

Single line:

"""Blah."""

Note there's no space between quotation mark and first word.

On 2014/05/27 20:58:35, jbudorick wrote:
> On 2014/05/24 00:22:39, frankf wrote:
> > no space after quotation mark. Also you didn't fix the onliner docstring
from
> > before :)
> 
> Done wrt no space. There's only one one liner docstring in this file, and it
> follows the convention you specified...?

[jbudorick, 2014-05-27 21:44:13]

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/292313015/diff/1/build/android/pylib/device/d...
build/android/pylib/device/device_utils.py:160: """ Reboot the device.
On 2014/05/27 21:12:10, frankf wrote:
> Multi-line:
> 
> """Line One.
> 
> Line2.
> """
> 
> Single line:
> 
> """Blah."""
> 
> Note there's no space between quotation mark and first word.
> 
> On 2014/05/27 20:58:35, jbudorick wrote:
> > On 2014/05/24 00:22:39, frankf wrote:
> > > no space after quotation mark. Also you didn't fix the onliner docstring
> from
> > > before :)
> > 
> > Done wrt no space. There's only one one liner docstring in this file, and it
> > follows the convention you specified...?
> 

Right, my point was that all of the docstrings in this file were already
following that convention aside from the no space thing. (In the current
revision of this CL, they follow that as well.)

[craigdh, 2014-05-29 18:40:13]

lgtm

[jbudorick, 2014-05-29 21:33:35]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-05-29 21:37:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/50001

[commit-bot: I haz the power, 2014-05-30 00:50:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[jbudorick, 2014-05-30 00:51:04]

The CQ bit was unchecked by jbudorick@chromium.org

[jbudorick, 2014-06-04 14:28:05]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-04 14:29:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/90001

[jbudorick, 2014-06-04 16:47:13]

The CQ bit was unchecked by jbudorick@chromium.org

[jbudorick, 2014-06-05 19:26:22]

made a nontrivial change to fix some issues with the bots. ptal.

[craigdh, 2014-06-09 17:18:31]

still lgtm.

[jbudorick, 2014-06-09 17:55:13]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-09 17:56:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/130001

[commit-bot: I haz the power, 2014-06-10 08:19:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-10 11:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 11:31:08]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-10 13:57:11]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-10 13:59:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/130001

[commit-bot: I haz the power, 2014-06-10 14:37:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-10 15:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 15:07:56]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-10 17:13:53]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-10 17:17:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/130001

[commit-bot: I haz the power, 2014-06-10 18:01:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-10 18:39:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 18:39:19]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-10 21:38:11]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-10 21:40:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/130001

[commit-bot: I haz the power, 2014-06-10 22:05:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-10 22:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 22:30:59]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-11 00:20:19]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-11 00:24:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/130001

[commit-bot: I haz the power, 2014-06-11 00:35:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-11 00:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 00:42:31]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-11 01:36:53]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-11 01:38:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/130001

[commit-bot: I haz the power, 2014-06-11 01:46:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-11 01:47:15]

The CQ bit was unchecked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-11 01:50:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 01:50:20]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[jbudorick, 2014-06-11 14:42:12]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-11 14:44:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/150001

[commit-bot: I haz the power, 2014-06-11 21:33:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:36:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:36:48]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[jbudorick, 2014-06-12 00:16:17]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:17:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/150001

[commit-bot: I haz the power, 2014-06-12 00:35:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-12 00:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:38:56]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[jbudorick, 2014-06-12 15:13:10]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-06-12 15:15:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbudorick@chromium.org/292313015/150001

[commit-bot: I haz the power, 2014-06-12 16:24:31]

Change committed as 276702

[please use gerrit instead, 2014-06-12 18:37:51]

Warning: this patch may have broken "contentshell_instrumentation_tests" on:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...

If the Android builder fails more than once in a row, then the sheriffs will
revert this patch. Sorry for the inconvenience :-)

[jbudorick, 2014-06-12 18:55:23]

On 2014/06/12 18:37:51, Rouslan Solomakhin wrote:
> Warning: this patch may have broken "contentshell_instrumentation_tests" on:
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%...
> 
> If the Android builder fails more than once in a row, then the sheriffs will
> revert this patch. Sorry for the inconvenience :-)

Given the failure and the corresponding logcat, I'll be surprised if this CL is
the actual cause, but then, I've been surprised before. :/