Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 292313008: Add class PreloadAddressValidator, interface to libaddressinput. (Closed)

Created:
6 years, 7 months ago by roubert
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add class PreloadAddressValidator, interface to libaddressinput. PreloadAddressValidator implements the same interface as Chromium's current AddressValidator but calls libaddressinput AddressValidator to perform the actual work, to simplify switching Chromium Autofill over to using libaddressinput. All existing test cases are ported. The suggestions functionality is currently stubbed out. R=rouslan@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274507

Patch Set 1 #

Patch Set 2 : Updated copyright headers. #

Patch Set 3 : Fix return value of CanonicalizeAdministrativeArea(). #

Patch Set 4 : Update with Synonyms. #

Patch Set 5 : Add constructor comment. #

Patch Set 6 : Add glue in PreloadAddressValidator for Suggestions. #

Patch Set 7 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -288 lines) Patch
A + third_party/libaddressinput/chromium/preload_address_validator.h View 1 2 3 4 5 4 chunks +65 lines, -87 lines 0 comments Download
A third_party/libaddressinput/chromium/preload_address_validator.cc View 1 2 3 4 5 1 chunk +144 lines, -0 lines 0 comments Download
A + third_party/libaddressinput/chromium/preload_address_validator_unittest.cc View 1 2 3 4 5 11 chunks +219 lines, -201 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
roubert
6 years, 7 months ago (2014-05-23 13:27:07 UTC) #1
please use gerrit instead
LGTM.
6 years, 6 months ago (2014-06-02 17:39:04 UTC) #2
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-02 17:39:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/roubert@google.com/292313008/110001
6 years, 6 months ago (2014-06-02 17:41:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-02 19:46:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 19:48:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/13028)
6 years, 6 months ago (2014-06-02 19:48:20 UTC) #7
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-02 20:16:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/roubert@google.com/292313008/110001
6 years, 6 months ago (2014-06-02 20:18:24 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-02 20:21:49 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 20:24:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/13028)
6 years, 6 months ago (2014-06-02 20:24:06 UTC) #12
roubert
The CQ bit was checked by roubert@google.com
6 years, 6 months ago (2014-06-03 08:18:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/roubert@google.com/292313008/110001
6 years, 6 months ago (2014-06-03 08:19:59 UTC) #14
roubert
The CQ bit was checked by roubert@google.com
6 years, 6 months ago (2014-06-03 08:20:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/roubert@google.com/292313008/110001
6 years, 6 months ago (2014-06-03 08:21:46 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 13:27:44 UTC) #17
Message was sent while issue was closed.
Change committed as 274507

Powered by Google App Engine
This is Rietveld 408576698