test/unittests/wasm/function-body-decoder-unittest.cc - Issue 2923103003: [WASM] Simplify SIMD shuffle opcodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/wasm/function-body-decoder-unittest.cc

Issue 2923103003: [WASM] Simplify SIMD shuffle opcodes. (Closed)

Patch Set: De-comment-out irregular shuffle code. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/wasm/function-body-decoder-unittest.cc

diff --git a/test/unittests/wasm/function-body-decoder-unittest.cc b/test/unittests/wasm/function-body-decoder-unittest.cc

index 091aa6046f0bed10287f55afd79af1ff65b3cb79..a30b297303a9615cf6c76988db26f6bdd2ab9c34 100644

--- a/test/unittests/wasm/function-body-decoder-unittest.cc

+++ b/test/unittests/wasm/function-body-decoder-unittest.cc

@@ -2627,8 +2627,6 @@ TEST_F(WasmOpcodeLengthTest, SimdExpressions) {

EXPECT_LENGTH_N(3, kSimdPrefix, static_cast<byte>(kExpr##name & 0xff));

FOREACH_SIMD_1_OPERAND_OPCODE(TEST_SIMD)

#undef TEST_SIMD

- EXPECT_LENGTH_N(6, kSimdPrefix, static_cast<byte>(kExprS32x4Shuffle & 0xff));

- EXPECT_LENGTH_N(10, kSimdPrefix, static_cast<byte>(kExprS16x8Shuffle & 0xff));

EXPECT_LENGTH_N(18, kSimdPrefix, static_cast<byte>(kExprS8x16Shuffle & 0xff));

#undef TEST_SIMD

// test for bad simd opcode