extensions/renderer/runtime_custom_bindings.cc - Issue 2923053002: Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/runtime_custom_bindings.cc

Issue 2923053002: Move MainWorldScriptContext accessor/method from WebFrame to WebLocalFrame. (Closed)

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/runtime_custom_bindings.cc

diff --git a/extensions/renderer/runtime_custom_bindings.cc b/extensions/renderer/runtime_custom_bindings.cc

index 66ed982fb558d4d96dabdee457734b7dc22969f8..fb1e4814c27afb189d5d4bb2bd0529f401230ac3 100644

--- a/extensions/renderer/runtime_custom_bindings.cc

+++ b/extensions/renderer/runtime_custom_bindings.cc

@@ -94,7 +94,7 @@ void RuntimeCustomBindings::GetExtensionViews(

// main views, not any subframes. (Returning subframes can cause broken

// behavior by treating an app window's iframe as its main frame, and maybe

// other nastiness).

- blink::WebFrame* web_frame = frame->GetWebFrame();

+ blink::WebLocalFrame* web_frame = frame->GetWebFrame();

if (web_frame->Top() != web_frame)

continue;