Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/browser/extensions/chrome_test_extension_loader.cc

Issue 2923013006: [Extensions Sync] Don't apply sync data for unsyncable extensions (Closed)
Patch Set: lazyboy's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_test_extension_loader.cc
diff --git a/chrome/browser/extensions/chrome_test_extension_loader.cc b/chrome/browser/extensions/chrome_test_extension_loader.cc
index 9bc6272ed4406d049d10d04c4aaf9a6866a45551..aef672fd5907fcd6fa596c0eca47eef021934328 100644
--- a/chrome/browser/extensions/chrome_test_extension_loader.cc
+++ b/chrome/browser/extensions/chrome_test_extension_loader.cc
@@ -104,6 +104,10 @@ base::FilePath ChromeTestExtensionLoader::PackExtension(
return base::FilePath();
}
+ if (!temp_dir_.CreateUniqueTempDir()) {
+ ADD_FAILURE() << "Could not create unique temp dir.";
+ return base::FilePath();
+ }
base::FilePath crx_path = temp_dir_.GetPath().AppendASCII("temp.crx");
if (base::PathExists(crx_path)) {
ADD_FAILURE() << "Crx path exists: " << crx_path.value()
@@ -118,7 +122,8 @@ base::FilePath ChromeTestExtensionLoader::PackExtension(
return base::FilePath();
}
- base::FilePath* pem_path_to_use = &fallback_pem_path;
+ base::FilePath empty_path;
+ base::FilePath* pem_path_to_use = &empty_path;
if (!pem_path_.empty()) {
pem_path_to_use = &pem_path_;
if (!base::PathExists(pem_path_)) {
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_sync_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698