Fix memory leak in extension pref store...

chrome/browser/extensions/extension_pref_store.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_pref_store.h"
 
 #include "base/logging.h"
+#include "base/stl_util-inl.h"
 #include "base/values.h"
 #include "chrome/browser/pref_service.h"
 
 ExtensionPrefStore::ExtensionPrefStore(PrefService* pref_service)
     : pref_service_(pref_service),
       prefs_(new DictionaryValue()) {
 }
 
+ExtensionPrefStore::~ExtensionPrefStore() {
+  STLDeleteElements(&extension_stack_);
+}
+
 // This could be sped up by keeping track of which extension currently controls
 // a given preference, among other optimizations. But we estimate that fewer
 // than 10 installed extensions will be trying to control any preferences, so
 // stick with this simpler algorithm until it causes a problem.
 void ExtensionPrefStore::UpdateOnePref(const wchar_t* path) {
   // Query the PrefService to find the current value for this pref.
   // pref_service_ might be null in unit tests.
   scoped_ptr<Value> old_value;
   if (pref_service_) {
     old_value.reset(
@@ skipping 54 matching lines @@
   UpdateOnePref(pref_path);
 }
 
 void ExtensionPrefStore::UninstallExtension(std::string extension_id) {
   // Remove this extension from the stack.
   scoped_ptr<PrefValueMap> pref_values;
   for (ExtensionStack::iterator i = extension_stack_.begin();
       i != extension_stack_.end(); ++i) {
     if ((*i)->extension_id == extension_id) {
       pref_values.reset((*i)->pref_values);
+      delete *i;
       extension_stack_.erase(i);
       break;
     }
   }
   if (!pref_values.get())
     return;
 
   UpdatePrefs(pref_values.get());
 }
 
 void ExtensionPrefStore::GetExtensionIDs(std::vector<std::string>* result) {
   for (ExtensionStack::iterator i = extension_stack_.begin();
       i != extension_stack_.end(); ++i) {
     (*result).push_back((*i)->extension_id);
   }
 }