net/disk_cache/simple/simple_index_file.h - Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_index_file.h

Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Patch Set: omewhat better take at higher-level HC::T impl, a bit lessy hacky, and actually write to cache now. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_index_file.h

diff --git a/net/disk_cache/simple/simple_index_file.h b/net/disk_cache/simple/simple_index_file.h

index 0f10094b0a4f2a13079ecf083bcd1192b884e47e..dca0c0907b76962b1a0082a016a583ec6ffeac11 100644

--- a/net/disk_cache/simple/simple_index_file.h

+++ b/net/disk_cache/simple/simple_index_file.h

@@ -67,6 +67,7 @@ class NET_EXPORT_PRIVATE SimpleIndexFile {

SimpleIndex::IndexWriteToDiskReason reason() const { return reason_; }

uint64_t entry_count() const { return entry_count_; }

+ bool has_memory_entry_data() const { return version_ >= 8; }

private:

FRIEND_TEST_ALL_PREFIXES(IndexMetadataTest, Basics);