net/disk_cache/simple/simple_backend_impl.h - Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_backend_impl.h

Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Patch Set: omewhat better take at higher-level HC::T impl, a bit lessy hacky, and actually write to cache now. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_backend_impl.h

diff --git a/net/disk_cache/simple/simple_backend_impl.h b/net/disk_cache/simple/simple_backend_impl.h

index aa7a3785afc91af89f04bb8b75b344ee207d6690..0107d1ff287942c76507898459bfd1f3202a9ae4 100644

--- a/net/disk_cache/simple/simple_backend_impl.h

+++ b/net/disk_cache/simple/simple_backend_impl.h

@@ -120,6 +120,8 @@ class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend,

size_t DumpMemoryStats(

base::trace_event::ProcessMemoryDump* pmd,

const std::string& parent_absolute_name) const override;

+ uint8_t GetMemoryEntryData(const std::string& key) override;

+ void SetMemoryEntryData(const std::string& key, uint8_t data) override;

private:

class SimpleIterator;