net/disk_cache/simple/simple_backend_impl.h - Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_backend_impl.h

Issue 2922973003: RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

Patch Set: - Implement support for oracle bytes in MockHttpCache, so the code actually gets exercised in tests… Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_backend_impl.h

diff --git a/net/disk_cache/simple/simple_backend_impl.h b/net/disk_cache/simple/simple_backend_impl.h

index aa7a3785afc91af89f04bb8b75b344ee207d6690..60c4f79a99f6cd4ff928b142215f8ac69b160158 100644

--- a/net/disk_cache/simple/simple_backend_impl.h

+++ b/net/disk_cache/simple/simple_backend_impl.h

@@ -98,6 +98,10 @@ class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend,

int OpenEntry(const std::string& key,

Entry** entry,

const CompletionCallback& callback) override;

+ int OpenEntryWithOracleByte(const std::string& key,

+ Entry** entry,

+ const OracleCallback& oracle,

+ const CompletionCallback& callback) override;

int CreateEntry(const std::string& key,

Entry** entry,

const CompletionCallback& callback) override;