RFC: use some in-memory state in SimpleCache to quickly cache-miss some CantConditionalize cases

net/http/http_cache_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_cache_transaction.h"
 
 #include "build/build_config.h"  // For OS_POSIX
 
 #if defined(OS_POSIX)
 #include <unistd.h>
@@ skipping 51 matching lines @@
 
 void RecordNoStoreHeaderHistogram(int load_flags,
                                   const HttpResponseInfo* response) {
   if (load_flags & LOAD_MAIN_FRAME_DEPRECATED) {
     UMA_HISTOGRAM_BOOLEAN(
         "Net.MainFrameNoStore",
         response->headers->HasHeaderValue("cache-control", "no-store"));
   }
 }
 
+disk_cache::Backend::OracleJudgement CheckIfUnusable(uint8_t flags) {
+  // If the entry is marked as an unused prefetch, we have to open it up
+  // to check.
+  if (flags & HttpCache::OBH_UNUSED_SINCE_PREFETCH)
+    return disk_cache::Backend::OracleJudgement::HIT;
+  if ((flags & HttpCache::OBH_ZERO_LIFETIME) &&
+      (flags & HttpCache::OBH_RESPONSE_CANT_CONDITIONALIZE)) {
+    // TODO(morlovich): Just zero-lifetime is sufficient for e.g.
+    // PUT/DELETE, also could potentially encode vary-mismatch case.
+    return disk_cache::Backend::OracleJudgement::MISS_AND_DOOM;
+  }
+
+  // Default
+  return disk_cache::Backend::OracleJudgement::HIT;
+}
+
 }  // namespace
 
 #define CACHE_STATUS_HISTOGRAMS(type)                                        \
   do {                                                                       \
     UMA_HISTOGRAM_ENUMERATION("HttpCache.Pattern" type, cache_entry_status_, \
                               CacheEntryStatus::ENTRY_MAX);                  \
     if (validation_request) {                                                \
       UMA_HISTOGRAM_ENUMERATION("HttpCache.ValidationCause" type,            \
                                 validation_cause_, VALIDATION_CAUSE_MAX);    \
     }                                                                        \
@@ skipping 902 matching lines @@
   return OK;
 }
 
 int HttpCache::Transaction::DoOpenEntry() {
   TRACE_EVENT0("io", "HttpCacheTransaction::DoOpenEntry");
   DCHECK(!new_entry_);
   TransitionToState(STATE_OPEN_ENTRY_COMPLETE);
   cache_pending_ = true;
   net_log_.BeginEvent(NetLogEventType::HTTP_CACHE_OPEN_ENTRY);
   first_cache_access_since_ = TimeTicks::Now();
-  return cache_->OpenEntry(cache_key_, &new_entry_, this);
+  // See if we could potentially quick reject the entry.
+  if (!(effective_load_flags_ & LOAD_SKIP_CACHE_VALIDATION))
+    return cache_->OpenEntry(cache_key_, &new_entry_,
+                             base::Bind(&CheckIfUnusable), this);
+  return cache_->OpenEntry(cache_key_, &new_entry_,
+                           disk_cache::Backend::OracleCallback(), this);
 }
 
 int HttpCache::Transaction::DoOpenEntryComplete(int result) {
   TRACE_EVENT0("io", "HttpCacheTransaction::DoOpenEntryComplete");
   // It is important that we go to STATE_ADD_TO_ENTRY whenever the result is
   // OK, otherwise the cache will end up with an active entry without any
   // transaction attached.
   net_log_.EndEventWithNetErrorCode(NetLogEventType::HTTP_CACHE_OPEN_ENTRY,
                                     result);
   cache_pending_ = false;
@@ skipping 1325 matching lines @@
       stale_entry_freshness_ = lifetimes.freshness;
       stale_entry_age_ = response_.headers->GetCurrentAge(
           response_.request_time, response_.response_time,
           cache_->clock_->Now());
     }
   }
 
   return validation_required_by_headers;
 }
 
+bool HttpCache::Transaction::ResponseConditionalizable(
+    std::string* etag_value,
+    std::string* last_modified_value) {
+  DCHECK(response_.headers.get());
+
+  // This only makes sense for cached 200 or 206 responses.
+  if (response_.headers->response_code() != 200 &&
+      response_.headers->response_code() != 206) {
+    return false;
+  }
+
+  // ### this looks scary.
+  DCHECK(response_.headers->response_code() != 206 ||
+         response_.headers->HasStrongValidators());
+
+  // Just use the first available ETag and/or Last-Modified header value.
+  // TODO(darin): Or should we use the last?
+
+  if (response_.headers->GetHttpVersion() >= HttpVersion(1, 1))
+    response_.headers->EnumerateHeader(NULL, "etag", etag_value);
+
+  response_.headers->EnumerateHeader(NULL, "last-modified",
+                                     last_modified_value);
+
+  if (etag_value->empty() && last_modified_value->empty())
+    return false;
+
+  return true;
+}
+
 bool HttpCache::Transaction::ConditionalizeRequest() {
   DCHECK(response_.headers.get());
 
   if (request_->method == "PUT" || request_->method == "DELETE")
     return false;
 
-  // This only makes sense for cached 200 or 206 responses.
-  if (response_.headers->response_code() != 200 &&
-      response_.headers->response_code() != 206) {
-    return false;
-  }
-
   if (fail_conditionalization_for_test_)
     return false;
 
-  DCHECK(response_.headers->response_code() != 206 ||
-         response_.headers->HasStrongValidators());
+  std::string etag_value;
+  std::string last_modified_value;
+  if (!ResponseConditionalizable(&etag_value, &last_modified_value))
+    return false;
 
-  // Just use the first available ETag and/or Last-Modified header value.
-  // TODO(darin): Or should we use the last?
-
-  std::string etag_value;
-  if (response_.headers->GetHttpVersion() >= HttpVersion(1, 1))
-    response_.headers->EnumerateHeader(NULL, "etag", &etag_value);
-
-  std::string last_modified_value;
-  if (!vary_mismatch_) {
-    response_.headers->EnumerateHeader(NULL, "last-modified",
-                                       &last_modified_value);
+  if (vary_mismatch_) {
+    // Can't rely on last-modified if vary is different.
+    last_modified_value.clear();
+    if (etag_value.empty())
+      return false;
   }
 
-  if (etag_value.empty() && last_modified_value.empty())
-    return false;
-
   if (!partial_) {
     // Need to customize the request, so this forces us to allocate :(
     custom_request_.reset(new HttpRequestInfo(*request_));
     request_ = custom_request_.get();
   }
   DCHECK(custom_request_.get());
 
   bool use_if_range =
       partial_ && !partial_->IsCurrentRangeCached() && !invalid_range_;
 
@@ skipping 240 matching lines @@
   if (truncated)
     DCHECK_EQ(200, response_.headers->response_code());
 
   // When writing headers, we normally only write the non-transient headers.
   bool skip_transient_headers = true;
   scoped_refptr<PickledIOBuffer> data(new PickledIOBuffer());
   response_.Persist(data->pickle(), skip_transient_headers, truncated);
   data->Done();
 
   io_buf_len_ = data->pickle()->size();
+
+  uint8_t hints = 0;
+  // ### recomputing this too much?
+  if (response_.headers->GetFreshnessLifetimes(response_.response_time)
+          .freshness.is_zero())
+    hints |= HttpCache::OBH_ZERO_LIFETIME;
+  std::string etag_ignored, last_modified_ignored;
+  if (!ResponseConditionalizable(&etag_ignored, &last_modified_ignored))
+    hints |= HttpCache::OBH_RESPONSE_CANT_CONDITIONALIZE;
+  if (response_.unused_since_prefetch)
+    hints |= HttpCache::OBH_UNUSED_SINCE_PREFETCH;
+  entry_->disk_entry->SetOracleByte(hints);
+
   return entry_->disk_entry->WriteData(kResponseInfoIndex, 0, data.get(),
                                        io_buf_len_, io_callback_, true);
 }
 
 int HttpCache::Transaction::OnWriteResponseInfoToEntryComplete(int result) {
   if (!entry_)
     return OK;
   if (net_log_.IsCapturing()) {
     net_log_.EndEventWithNetErrorCode(NetLogEventType::HTTP_CACHE_WRITE_INFO,
                                       result);
@@ skipping 373 matching lines @@
 }
 
 void HttpCache::Transaction::TransitionToState(State state) {
   // Ensure that the state is only set once per Do* state.
   DCHECK(in_do_loop_);
   DCHECK_EQ(STATE_UNSET, next_state_) << "Next state is " << state;
   next_state_ = state;
 }
 
 }  // namespace net