Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2922903003: Fix Accessibility issue when new translate infobar is visiable. (Closed)

Created:
3 years, 6 months ago by Leo
Modified:
3 years, 6 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Accessibility issue when new translate infobar is visible. In the new compact layout, we removed messageView which was used to provide accessibility message when talkback is on. In order to make a quick fix and patch it into the M60 release, we decide to add an existing string as its general accessibility message when the infobar is shown. BUG=723115 Review-Url: https://codereview.chromium.org/2922903003 Cr-Commit-Position: refs/heads/master@{#477185} Committed: https://chromium.googlesource.com/chromium/src/+/f1671492eb9f8403e391bab744ec1ac57e171e91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Leo
This is a quick fix for accessibility issue. In order to patch it into M60 ...
3 years, 6 months ago (2017-06-05 03:42:53 UTC) #3
mdjones
lgtm % fix your commit message: https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list-descriptions
3 years, 6 months ago (2017-06-05 16:10:19 UTC) #4
Leo
On 2017/06/05 16:10:19, mdjones wrote: > lgtm % fix your commit message: > https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list-descriptions Thanks ...
3 years, 6 months ago (2017-06-06 00:28:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922903003/1
3 years, 6 months ago (2017-06-06 00:29:13 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 03:52:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1671492eb9f8403e391bab744ec...

Powered by Google App Engine
This is Rietveld 408576698