Add List notification support to new-style notification.

ui/message_center/views/notification_view_md.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/views/notification_view_md.h"
 
 #include <stddef.h>
 
 #include "base/strings/string_util.h"
 #include "ui/base/cursor/cursor.h"
@@ skipping 68 matching lines @@
   const gfx::ImageSkia masked_small_image =
       gfx::ImageSkiaOperations::CreateMaskedImage(foreground, icon);
   return gfx::ImageSkiaOperations::CreateSuperimposedImage(background,
                                                            masked_small_image);
 }
 
 const gfx::ImageSkia GetProductIcon() {
   return gfx::CreateVectorIcon(kProductIcon, kSmallImageColor);
 }
 
+// ItemView ////////////////////////////////////////////////////////////////////
+
+// ItemViews are responsible for drawing each list notification item's title and
+// message next to each other within a single column.
+class ItemView : public views::View {
+ public:
+  explicit ItemView(const message_center::NotificationItem& item);
+  ~ItemView() override;
+
+  // Overridden from views::View:
+  void SetVisible(bool visible) override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ItemView);
+};
+
+ItemView::ItemView(const message_center::NotificationItem& item) {
+  SetLayoutManager(
+      new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0,
+                           message_center::kItemTitleToMessagePadding));
+
+  views::Label* title = new views::Label(item.title);
+  title->set_collapse_when_hidden(true);
+  title->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  title->SetEnabledColor(message_center::kRegularTextColor);
+  title->SetBackgroundColor(message_center::kRegularTextBackgroundColor);
+  AddChildView(title);
+
+  views::Label* message = new views::Label(item.message);
+  message->set_collapse_when_hidden(true);
+  message->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  message->SetEnabledColor(message_center::kDimTextColor);
+  message->SetBackgroundColor(message_center::kDimTextBackgroundColor);
+  AddChildView(message);
+
+  PreferredSizeChanged();

[yoshiki, 2017/06/05 04:29:13]

I think this is not necessary, since the preferred size is not changed here. 

[tetsui, 2017/06/13 03:44:33]

Done.

+  SchedulePaint();

[yoshiki, 2017/06/05 04:29:13]

I also think this is not necessary, since adding a view calls SchedulePaint()
eventually.

(see.
https://cs.chromium.org/chromium/src/ui/views/view.cc?rcl=683485cf448a4b1e083...)

[tetsui, 2017/06/13 03:44:33]

Done.

+}
+
+ItemView::~ItemView() {}
+
+void ItemView::SetVisible(bool visible) {
+  views::View::SetVisible(visible);
+  for (int i = 0; i < child_count(); ++i)
+    child_at(i)->SetVisible(visible);

[yoshiki, 2017/06/05 04:29:13]

It looks necessary? I think setting visibility of the parent automatically hides
the children. Please write a reason as a comment if it's truly necessary.

[tetsui, 2017/06/13 03:44:33]

Done.

+}
+
 }  // anonymous namespace
 
 // ////////////////////////////////////////////////////////////
 // NotificationViewMD
 // ////////////////////////////////////////////////////////////
 
 views::View* NotificationViewMD::TargetForRect(views::View* root,
                                                const gfx::Rect& rect) {
   CHECK_EQ(root, this);
 
@@ skipping 266 matching lines @@
   }
 }
 
 void NotificationViewMD::CreateOrUpdateProgressBarView(
     const Notification& notification) {
   // TODO(yoshiki): Implement this.
 }
 
 void NotificationViewMD::CreateOrUpdateListItemViews(
     const Notification& notification) {
-  // TODO(yoshiki): Implement this.
+  for (auto* item_view : item_views_)
+    delete item_view;
+  item_views_.clear();
+
+  const std::vector<NotificationItem>& items = notification.items();
+
+  if (items.size() == 0)
+    return;
+
+  DCHECK(top_view_);

[yoshiki, 2017/06/05 04:29:13]

Should we check main_view_ instead of top_view_, since we're adding views to
main_view_?

[tetsui, 2017/06/13 03:44:33]

Done.

+  for (size_t i = 0; i < items.size() && i < kNotificationMaximumItems; ++i) {
+    ItemView* item_view = new ItemView(items[i]);
+    item_views_.push_back(item_view);
+    main_view_->AddChildView(item_view);
+  }
 }
 
 void NotificationViewMD::CreateOrUpdateIconView(
     const Notification& notification) {
   // TODO(yoshiki): Implement this.
 }
 
 void NotificationViewMD::CreateOrUpdateSmallIconView(
     const Notification& notification) {
   gfx::ImageSkia icon =
@@ skipping 60 matching lines @@
       close_button_->SetVisible(target_visibility);
   }
 
   if (settings_button_) {
     if (target_visibility != settings_button_->visible())
       settings_button_->SetVisible(target_visibility);
   }
 }
 
 }  // namespace message_center