Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 292263003: Comment out not yet used flags from BUILD.gn (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Comment out not yet used flags from BUILD.gn gn started to complain about unused variables BUG=none R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-21 11:31:14 UTC) #1
dcarney
lgtm
6 years, 7 months ago (2014-05-21 11:51:21 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-21 11:57:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698