telemetry/telemetry/internal/actions/action_runner.py - Issue 2922593004: [telemetry] Provide some more specific exception classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/actions/action_runner.py

Issue 2922593004: [telemetry] Provide some more specific exception classes (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/actions/action_runner.py

diff --git a/telemetry/telemetry/internal/actions/action_runner.py b/telemetry/telemetry/internal/actions/action_runner.py

index ec2a5eac8e28db8da31ed2c215a0baed16a7f38d..fbfc98a3a6aca0a1bedea05e715b3e045c1a14c4 100644

--- a/telemetry/telemetry/internal/actions/action_runner.py

+++ b/telemetry/telemetry/internal/actions/action_runner.py

@@ -157,7 +157,7 @@ class ActionRunner(object):

self.Wait(_DUMP_WAIT_TIME)

dump_id = self.tab.browser.DumpMemory()

if not dump_id:

- raise exceptions.Error('Unable to obtain memory dump')

+ raise exceptions.StoryActionError('Unable to obtain memory dump')

return dump_id

def Navigate(self, url, script_to_evaluate_on_commit=None,