components/ntp_snippets/pref_names.h - Issue 2922543002: [NTP::Push] Add Content Suggestions GCM App Handler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/pref_names.h

Issue 2922543002: [NTP::Push] Add Content Suggestions GCM App Handler (Closed)

Patch Set: peter@ comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_snippets/breaking_news/subscription_manager.cc ('K') | « components/ntp_snippets/breaking_news/subscription_manager_unittest.cc ('k') | components/ntp_snippets/pref_names.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_	5 #ifndef COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_

6 #define COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_	6 #define COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_

7	7

8 namespace ntp_snippets {	8 namespace ntp_snippets {

9 namespace prefs {	9 namespace prefs {

10	10

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87	87

88 // The pref name for the current order of categories and their clicks.	88 // The pref name for the current order of categories and their clicks.

89 extern const char kClickBasedCategoryRankerOrderWithClicks[];	89 extern const char kClickBasedCategoryRankerOrderWithClicks[];

90 // The pref name for the time when last click decay has happened.	90 // The pref name for the time when last click decay has happened.

91 extern const char kClickBasedCategoryRankerLastDecayTime[];	91 extern const char kClickBasedCategoryRankerLastDecayTime[];

92	92

93 // The pref name for the subscription token used when subscription for breaking	93 // The pref name for the subscription token used when subscription for breaking

94 // news push updates,	94 // news push updates,

95 extern const char kContentSuggestionsSubscriptionDataToken[];	95 extern const char kContentSuggestionsSubscriptionDataToken[];

96	96

	97 // The pref name for the subscription token received from the gcm server. As
	jkrcal 2017/06/09 09:10:10 The comment does not clarify the difference to kCo The comment does not clarify the difference to kContentSuggestionsSubscriptionDataToken to me. Can you please expand the comments a bit? mamir 2017/06/09 13:52:58 PTAL. Show quoted text On 2017/06/09 09:10:10, jkrcal wrote: > The comment does not clarify the difference to > kContentSuggestionsSubscriptionDataToken to me. Can you please expand the > comments a bit? PTAL.
	98 // recommended by the GCM team, it is cached in pref for faster bookkeeping to

	99 // see if subscription exists..
	jkrcal 2017/06/09 09:10:10 nit: Remove one of the trailing dots. nit: Remove one of the trailing dots. mamir 2017/06/09 13:52:58 Done. Show quoted text On 2017/06/09 09:10:10, jkrcal wrote: > nit: Remove one of the trailing dots. Done.
	100 extern const char kContentSuggestionsGCMSubscriptionTokenCache[];

	101

97 } // namespace prefs	102 } // namespace prefs

98 } // namespace ntp_snippets	103 } // namespace ntp_snippets

99	104

100 #endif // COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_	105 #endif // COMPONENTS_NTP_SNIPPETS_PREF_NAMES_H_

OLD	NEW