[Android] Implement GetRuleIterator for channels provider

chrome/browser/notifications/notification_channels_provider_android.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_CHANNELS_PROVIDER_ANDROID_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_CHANNELS_PROVIDER_ANDROID_H_
 
 #include <string>
 
 #include "base/macros.h"
 #include "components/content_settings/core/browser/content_settings_observable_provider.h"
 #include "components/content_settings/core/browser/content_settings_observer.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "components/keyed_service/core/keyed_service.h"
 
 namespace {
 
 // A Java counterpart will be generated for this enum.
 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.notifications
 enum NotificationChannelStatus { ENABLED, BLOCKED, UNAVAILABLE };
 
+struct Channel {
+  std::string origin;
+  NotificationChannelStatus status;

[Peter Beverloo, 2017/06/02 15:14:26]

nit: give a default value

[awdf, 2017/06/02 16:59:48]

Done.

+};
+
 }  // anonymous namespace

[Peter Beverloo, 2017/06/02 15:14:26]

Sorry that I missed this earlier - we shouldn't be using an anonymous namespace
in a header file, is doesn't mean anything. If you qualify Channel as
NotificationChannel we can just have them on the global scope. Alternatively you
can add them as members of NotificationChannelsProviderAndroid.

[awdf, 2017/06/02 16:59:48]

Done.

 
 // This class provides notification content settings from system notification
 // channels on Android O+. This provider takes precedence over pref-provided
 // content settings, but defers to supervised user and policy settings - see
 // ordering of the ProviderType enum values in HostContentSettingsMap.
 class NotificationChannelsProviderAndroid
     : public content_settings::ObservableProvider {
  public:
   // Helper class to make the JNI calls.
   class NotificationChannelsBridge {
    public:
     virtual ~NotificationChannelsBridge() = default;
     virtual bool ShouldUseChannelSettings() = 0;
     virtual void CreateChannel(const std::string& origin, bool enabled) = 0;
     virtual NotificationChannelStatus GetChannelStatus(
         const std::string& origin) = 0;
     virtual void DeleteChannel(const std::string& origin) = 0;
+    virtual std::vector<Channel> GetChannels() = 0;
   };
 
   NotificationChannelsProviderAndroid();
   ~NotificationChannelsProviderAndroid() override;
 
   // ProviderInterface methods:
   std::unique_ptr<content_settings::RuleIterator> GetRuleIterator(
       ContentSettingsType content_type,
       const content_settings::ResourceIdentifier& resource_identifier,
       bool incognito) const override;
@@ skipping 11 matching lines @@
       std::unique_ptr<NotificationChannelsBridge> bridge);
   friend class NotificationChannelsProviderAndroidTest;
 
   std::unique_ptr<NotificationChannelsBridge> bridge_;
   bool should_use_channels_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationChannelsProviderAndroid);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_CHANNELS_PROVIDER_ANDROID_H_