Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.cc

Issue 2922453002: Remove validation retry logic from DeviceSettingsService (Closed)
Patch Set: Adding back IsInitialized() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/device_settings_provider.cc
diff --git a/chrome/browser/chromeos/settings/device_settings_provider.cc b/chrome/browser/chromeos/settings/device_settings_provider.cc
index 6e0e106ad7c4e18b0bac19ba6d53fb4ce4ce8098..79d581b853110156249a496c687a137d6a5d9cfa 100644
--- a/chrome/browser/chromeos/settings/device_settings_provider.cc
+++ b/chrome/browser/chromeos/settings/device_settings_provider.cc
@@ -890,7 +890,6 @@ bool DeviceSettingsProvider::UpdateFromService() {
VLOG(1) << "No policies present yet, will use the temp storage.";
trusted_status_ = PERMANENTLY_UNTRUSTED;
break;
- case DeviceSettingsService::STORE_POLICY_ERROR:
case DeviceSettingsService::STORE_VALIDATION_ERROR:
case DeviceSettingsService::STORE_INVALID_POLICY:
case DeviceSettingsService::STORE_OPERATION_FAILED:
@@ -898,13 +897,6 @@ bool DeviceSettingsProvider::UpdateFromService() {
<< device_settings_service_->status();
trusted_status_ = PERMANENTLY_UNTRUSTED;
break;
- case DeviceSettingsService::STORE_TEMP_VALIDATION_ERROR:
- // The policy has failed to validate due to temporary error but it might
- // take a long time until we recover so behave as it is a permanent error.
- LOG(ERROR) << "Failed to retrieve cros policies because a temporary "
- << "validation error has occurred. Retrying might succeed.";
- trusted_status_ = PERMANENTLY_UNTRUSTED;
- break;
}
// Notify the observers we are done.

Powered by Google App Engine
This is Rietveld 408576698