Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 292243003: Encoding API: Expose 'fatal' and 'ignoreBOM' readonly attributes (Closed)

Created:
6 years, 7 months ago by jsbell
Modified:
6 years, 6 months ago
Reviewers:
jungshik at Google
CC:
blink-reviews
Visibility:
Public.

Description

Encoding API: Expose 'fatal' and 'ignoreBOM' readonly attributes From private conversation with annevk - make the properties of the TextDecoder object inspectable. BUG=375847 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174977

Patch Set 1 : re-up #

Patch Set 2 : Rebased #

Patch Set 3 : Regen test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M LayoutTests/fast/encoding/api/fatal-flag.html View 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/encoding/api/fatal-flag-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/encoding/api/textdecoder-ignorebom.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/encoding/api/textdecoder-ignorebom-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/encoding/TextDecoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/encoding/TextDecoder.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
lgtm
6 years, 6 months ago (2014-05-27 17:12:26 UTC) #1
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-05-28 16:25:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/292243003/60001
6 years, 6 months ago (2014-05-28 16:25:21 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 17:47:49 UTC) #4
Message was sent while issue was closed.
Change committed as 174977

Powered by Google App Engine
This is Rietveld 408576698