Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 292243002: Add mojo bindings backpointer tests. (Closed)

Created:
6 years, 7 months ago by Tom Sepez
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen1
Visibility:
Public.

Description

Add mojo bindings backpointer tests. Simple bit-flipping won't generate negative offsets (e.g. large positive offsets that overflow), so we add a test where we specifically create the possibility of such. Also simplify argument passing in the cpp -> js direction, since there isn't a need to build lists here. We're only interested in the other direction. Remove some stray "explicit" keywords and reduce the echo test iterations since it doesn't prove much. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271806

Patch Set 1 #

Patch Set 2 : Fix comments in mojom. #

Patch Set 3 : Remove unused variables. #

Total comments: 1

Patch Set 4 : remove stray "explicit" keywords. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -33 lines) Patch
M mojo/apps/js/test/js_to_cpp.mojom View 1 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 2 3 11 chunks +69 lines, -19 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.js View 1 2 5 chunks +58 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
lgtm w/nit https://codereview.chromium.org/292243002/diff/40001/mojo/apps/js/test/js_to_cpp_unittest.cc File mojo/apps/js/test/js_to_cpp_unittest.cc (right): https://codereview.chromium.org/292243002/diff/40001/mojo/apps/js/test/js_to_cpp_unittest.cc#newcode315 mojo/apps/js/test/js_to_cpp_unittest.cc:315: explicit BackPointerCppSideConnection() : termination_seen_(false) {} nit: no ...
6 years, 7 months ago (2014-05-20 18:10:23 UTC) #1
Tom Sepez
Trung, please review. Thanks.
6 years, 7 months ago (2014-05-20 18:11:24 UTC) #2
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-20 18:18:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/292243002/60001
6 years, 7 months ago (2014-05-20 18:18:39 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 01:59:13 UTC) #5
Message was sent while issue was closed.
Change committed as 271806

Powered by Google App Engine
This is Rietveld 408576698