Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2922343002: Paint table row backgound behind visibility:hidden cell (Closed)

Created:
3 years, 6 months ago by cathiechentx
Modified:
3 years, 6 months ago
Reviewers:
Xianzhu, Wei Xiaohai
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Paint table row backgound behind visibility:hidden cell PaintContainerBackgroundBehindCell should check the visibility of background_object not layout_table_cell_. BUG=714583 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/paint/tables/row-background-behind-hidden-cell.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/tables/row-background-behind-hidden-cell-expected.html View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
cathiechentx
Hi xianzhu@, Could you please take a look at this? Thanks! :)
3 years, 6 months ago (2017-06-06 10:20:31 UTC) #4
Xianzhu
lgtm LGTM! Thanks!
3 years, 6 months ago (2017-06-06 15:54:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922343002/1
3 years, 6 months ago (2017-06-06 15:55:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/4936)
3 years, 6 months ago (2017-06-06 17:05:30 UTC) #9
cathiechentx
3 years, 6 months ago (2017-06-07 13:31:20 UTC) #10
Failed on: fast/table/invisible-cell-background.html

Looks like this is a historic issue.

This issue is introduced by
https://chromium.googlesource.com/chromium/src/+/10dbbd8cd3b5e9f3d5acd8f5b566...
which uploaded a test case (fast/table/invisible-cell-background.html) to make
sure "Don't paint any background if the cell is not visible."

Safari and Edge have the same behavior as blink. (Don't paint any background if
the cell is not visible.)

Firefox is different but weird too.

But according to the rule of visibility, we should paint parent background if
the cell isn't visible.

Powered by Google App Engine
This is Rietveld 408576698