Disable VK overscroll for login/out-of-box.

chrome/browser/chromeos/login/ui/login_display_host_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
 
 #include <vector>
 
 #include "ash/audio/sounds.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 65 matching lines @@
 #include "media/audio/sounds/sounds_manager.h"
 #include "ui/aura/window.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/layer.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/compositor/scoped_layer_animation_settings.h"
 #include "ui/events/event_utils.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/transform.h"
 #include "ui/keyboard/keyboard_controller.h"
+#include "ui/keyboard/keyboard_util.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/core/window_animations.h"
 #include "url/gurl.h"
 
 namespace {
 
 // Maximum delay for startup sound after 'loginPromptVisible' signal.
 const int kStartupSoundMaxDelayMs = 2000;
@@ skipping 179 matching lines @@
   virtual bool ShouldAdvanceFocusToTopLevelWidget() const OVERRIDE {
     return true;
   }
 
  private:
   views::Widget* widget_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginWidgetDelegate);
 };
 
+// Returns true if login should scroll user pods into view itself when virtual
+// keyboard is shown and disable vk overscroll.
+bool LoginScrollIntoViewEnabled() {
+  return !CommandLine::ForCurrentProcess()->HasSwitch(
+      chromeos::switches::kDisableLoginScrollIntoView);
+}
+
+// Disables virtual keyboard overscroll. Login UI will scroll user pods
+// into view on JS side when virtual keyboard is shown.
+void DisableKeyboardOverscroll() {
+  keyboard::SetKeyboardOverscrollEnabledOverrideValue(false);
+  keyboard::SetKeyboardOverscrollOverrideEnabled(true);
+}
+
+void ResetKeyboardOverscrollOverride() {
+  keyboard::SetKeyboardOverscrollOverrideEnabled(false);
+}
+
 }  // namespace
 
 namespace chromeos {
 
 // static
 LoginDisplayHost* LoginDisplayHostImpl::default_host_ = NULL;
 
 // static
 const int LoginDisplayHostImpl::kShowLoginWebUIid = 0x1111;
 
@@ skipping 133 matching lines @@
   DBusThreadManager::Get()->GetSessionManagerClient()->RemoveObserver(this);
   CrasAudioHandler::Get()->RemoveAudioObserver(this);
   if (keyboard::KeyboardController::GetInstance() && is_observing_keyboard_) {
     keyboard::KeyboardController::GetInstance()->RemoveObserver(this);
     is_observing_keyboard_ = false;
   }
 
   ash::Shell::GetInstance()->delegate()->
       RemoveVirtualKeyboardStateObserver(this);
 
+  if (LoginScrollIntoViewEnabled())
+    ResetKeyboardOverscrollOverride();
+
   views::FocusManager::set_arrow_key_traversal_enabled(false);
   ResetLoginWindowAndView();
 
   // Let chrome process exit after login/oobe screen if needed.
   chrome::DecrementKeepAliveCount();
 
   default_host_ = NULL;
   // TODO(tengs): This should be refactored. See crbug.com/314934.
   if (UserManager::Get()->IsCurrentUserNew()) {
     // DriveOptInController will delete itself when finished.
@@ skipping 75 matching lines @@
         auto_enrollment_controller_->RegisterProgressCallback(
             base::Bind(&LoginDisplayHostImpl::OnAutoEnrollmentProgress,
                        base::Unretained(this)));
   }
   return auto_enrollment_controller_.get();
 }
 
 void LoginDisplayHostImpl::StartWizard(
     const std::string& first_screen_name,
     scoped_ptr<base::DictionaryValue> screen_parameters) {
+  if (LoginScrollIntoViewEnabled())
+    DisableKeyboardOverscroll();
+
   startup_sound_honors_spoken_feedback_ = true;
   TryToPlayStartupSound();
 
   // Keep parameters to restore if renderer crashes.
   restore_path_ = RESTORE_WIZARD;
   wizard_first_screen_name_ = first_screen_name;
   if (screen_parameters.get())
     wizard_screen_parameters_.reset(screen_parameters->DeepCopy());
   else
     wizard_screen_parameters_.reset();
@@ skipping 24 matching lines @@
 WizardController* LoginDisplayHostImpl::GetWizardController() {
   return wizard_controller_.get();
 }
 
 AppLaunchController* LoginDisplayHostImpl::GetAppLaunchController() {
   return app_launch_controller_.get();
 }
 
 void LoginDisplayHostImpl::StartUserAdding(
     const base::Closure& completion_callback) {
+  if (LoginScrollIntoViewEnabled())
+    DisableKeyboardOverscroll();
+
   restore_path_ = RESTORE_ADD_USER_INTO_SESSION;
   completion_callback_ = completion_callback;
   finalize_animation_type_ = ANIMATION_NONE;
   LOG(WARNING) << "Login WebUI >> user adding";
   if (!login_window_)
     LoadURL(GURL(kUserAddingURL));
   // We should emit this signal only at login screen (after reboot or sign out).
   login_view_->set_should_emit_login_prompt_visible(false);
 
   // Lock container can be transparent after lock screen animation.
@@ skipping 12 matching lines @@
   sign_in_controller_->Init(
       chromeos::UserManager::Get()->GetUsersAdmittedForMultiProfile());
   CHECK(webui_login_display_);
   GetOobeUI()->ShowSigninScreen(LoginScreenContext(),
                                 webui_login_display_,
                                 webui_login_display_);
 }
 
 void LoginDisplayHostImpl::StartSignInScreen(
     const LoginScreenContext& context) {
+  if (LoginScrollIntoViewEnabled())
+    DisableKeyboardOverscroll();
+
   startup_sound_honors_spoken_feedback_ = true;
   TryToPlayStartupSound();
 
   restore_path_ = RESTORE_SIGN_IN;
   is_showing_login_ = true;
   finalize_animation_type_ = ANIMATION_WORKSPACE;
 
   PrewarmAuthentication();
 
   if (waiting_for_wallpaper_load_ && !initialize_webui_hidden_) {
@@ skipping 250 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // LoginDisplayHostImpl, keyboard::KeyboardControllerObserver:
 // implementation:
 
 void LoginDisplayHostImpl::OnKeyboardBoundsChanging(
     const gfx::Rect& new_bounds) {
   if (new_bounds.IsEmpty() && !keyboard_bounds_.IsEmpty()) {
     // Keyboard has been hidden.
-    if (webui_login_display_)
+    if (webui_login_display_) {

[dzhioev (left Google), 2014/05/21 17:30:32]

Shouldn't we also set keyboard state once webui_login_display_ became available
(in CreateLoginDisplay method)?

[Nikita (slow), 2014/05/22 15:11:50]

When CreateLoginDisplay() is called neither handler is created nor JS side is
initialized.

Added to CoreOobeHandler::Initialize().

       webui_login_display_->ShowControlBar(true);
+      if (LoginScrollIntoViewEnabled())
+        webui_login_display_->SetKeyboardState(false);
+    }
   } else if (!new_bounds.IsEmpty() && keyboard_bounds_.IsEmpty()) {
     // Keyboard has been shown.
-    if (webui_login_display_)
+    if (webui_login_display_) {
       webui_login_display_->ShowControlBar(false);
+      if (LoginScrollIntoViewEnabled())
+        webui_login_display_->SetKeyboardState(true);
+    }
   }
 
   keyboard_bounds_ = new_bounds;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // LoginDisplayHostImpl, private
 
 void LoginDisplayHostImpl::ShutdownDisplayHost(bool post_quit_task) {
   if (shutting_down_)
@@ skipping 347 matching lines @@
   scoped_ptr<locale_util::SwitchLanguageCallback> callback(
       new locale_util::SwitchLanguageCallback(
           base::Bind(&OnLanguageSwitchedCallback, base::Passed(data.Pass()))));
 
   // Load locale keyboards here. Hardware layout would be automatically enabled.
   locale_util::SwitchLanguage(
       locale, true, true /* login_layouts_only */, callback.Pass());
 }
 
 }  // namespace chromeos