Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2922303002: Revert "Fix another warning in pkg/testing." (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
ahe, aam
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix another warning in pkg/testing." This reverts commit d935a7fd00f8727ff730dff2a0273999fa7faaa7. R=aam@google.com, ahe@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/433b7904c27dea2dca5f6fa650c99c553d9b5874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/testing/lib/src/analyze.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-06-06 01:40:10 UTC) #1
aam
LGTM Thanks!
3 years, 6 months ago (2017-06-06 01:43:56 UTC) #2
scheglov
3 years, 6 months ago (2017-06-06 01:44:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
433b7904c27dea2dca5f6fa650c99c553d9b5874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698