Introduce Zucchini in chromium

chrome/installer/zucchini/BUILD.gn

+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//chrome/process_version_rc_template.gni")
+import("//testing/test.gni")
+
+executable("zucchini") {
+  sources = [
+    "zucchini_main.cc",

[grt (UTC plus 2), 2017/06/09 08:22:53]

i see that //chrome/installer/setup:setup lists the .rc.version file as a
source. presumably this is so that the "setup" target is rebuilt if the
.rc.version file changes. this seems like the sort of thing that
process_version_rc_template *should* take care of, but it's not obvious to me
that it does. would you try building zucchini, touching the .rc.version file,
then building zucchini again (or use "ninja -v -d explain" or something like
that) to make sure that it's rebuilt in that case? if it isn't, please add the
.rc.version file as an explicit source here.

[etiennep, 2017/06/09 22:43:05]

Touching .rc.version effectively causes ninja to rebuild the executable, and
updates its informations - I believe that is because zucchini_exe_version
appears in deps.

+  ]
+
+  deps = [
+    "//base",

[grt (UTC plus 2), 2017/06/09 08:22:53]

this doesn't yet depend on base. please remove this until it does.

[etiennep, 2017/06/09 22:43:05]

Done.

+  ]
+
+  if (is_win) {
+    deps += [
+      ":zucchini_exe_version",
+    ]
+  }
+}
+
+if (is_win) {
+  process_version_rc_template("zucchini_exe_version") {
+    template_file = "zucchini_exe_version.rc.version"
+    output = "$target_gen_dir/zucchini_exe_version.rc"
+  }
+}
+
+test("zucchini_unittests") {
+  sources = []
+
+  deps = [
+    "//base/test:run_all_unittests",
+    "//testing/gtest",

[grt (UTC plus 2), 2017/06/09 08:22:53]

similar comment -- this doesn't yet directly depend on gtest. please add the
dependency when it is needed.

[etiennep, 2017/06/09 22:43:05]

Done.

+  ]
+}