Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2922233002: [ActiveSuggestionMarker #1] Introduce abstract StyleableMarker subclass of DocumentMarker (Closed)
Patch Set: Add test for IsStyleableMarker() Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/testing/Internals.cpp
diff --git a/third_party/WebKit/Source/core/testing/Internals.cpp b/third_party/WebKit/Source/core/testing/Internals.cpp
index 45b35aaebf2f2cd53dc0384b6fdd9415122b087a..09a4bf4b057ed23401a0145753c90f9aafecd161 100644
--- a/third_party/WebKit/Source/core/testing/Internals.cpp
+++ b/third_party/WebKit/Source/core/testing/Internals.cpp
@@ -1061,12 +1061,12 @@ static bool ParseColor(const String& value,
return true;
}
-static WTF::Optional<CompositionMarker::Thickness> ThicknessFrom(
+static WTF::Optional<StyleableMarker::Thickness> ThicknessFrom(
const String& thickness) {
if (EqualIgnoringASCIICase(thickness, "thin"))
- return CompositionMarker::Thickness::kThin;
+ return StyleableMarker::Thickness::kThin;
if (EqualIgnoringASCIICase(thickness, "thick"))
- return CompositionMarker::Thickness::kThick;
+ return StyleableMarker::Thickness::kThick;
return WTF::nullopt;
}
@@ -1078,7 +1078,7 @@ void Internals::addCompositionMarker(const Range* range,
DCHECK(range);
range->OwnerDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
- WTF::Optional<CompositionMarker::Thickness> thickness =
+ WTF::Optional<StyleableMarker::Thickness> thickness =
ThicknessFrom(thickness_value);
if (!thickness) {
exception_state.ThrowDOMException(
« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/StyleableMarker.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698