Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 292223003: Count blacklisting as an extension being disabled. Correctly. (Closed)

Created:
6 years, 7 months ago by not at google - send to devlin
Modified:
6 years, 7 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make ExtensionService::IsExtensionEnabled consider prefs blacklist state when determining if an extension is enabled before it's loaded or the service is ready. BUG=376963 R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273021

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 1 chunk +16 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
not at google - send to devlin
6 years, 7 months ago (2014-05-23 20:33:49 UTC) #1
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-05-23 20:49:57 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-05-23 20:51:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/292223003/20001
6 years, 7 months ago (2014-05-23 20:53:00 UTC) #4
not at google - send to devlin
(I got the wrong BUG, updated if you're curious)
6 years, 7 months ago (2014-05-23 21:11:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 00:21:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 02:50:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/19579)
6 years, 7 months ago (2014-05-24 02:50:06 UTC) #8
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-05-27 16:39:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/292223003/20001
6 years, 7 months ago (2014-05-27 16:40:20 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 20:54:37 UTC) #11
Message was sent while issue was closed.
Change committed as 273021

Powered by Google App Engine
This is Rietveld 408576698