third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 2922193002: Change hover element to HTML element when over root scrollbar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2922193002: Change hover element to HTML element when over root scrollbar (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index cdd7bf2d338a1413639fd2884df799b0706fe8bc..25e66cae3647375ea7e1220c11d22b869c4a9064 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -164,6 +164,12 @@ bool LayoutView::HitTestNoLifecycleUpdate(HitTestResult& result) {

if (scrollable_area && scrollable_area->GetLayoutBox() &&

scrollable_area->GetLayoutBox()->GetNode()) {

Node* node = scrollable_area->GetLayoutBox()->GetNode();

+ // If scrollbar belong's to Document, we should set innerNode to

bokan 2017/06/06 21:02:30 nit: belong's -> belongs

+ // HTMLElement to match other browser.

bokan 2017/06/06 21:02:30 HTMLElement is a class, to prevent confusion I'd r

+ if (node->IsDocumentNode())

+ node = node->GetDocument().documentElement();

result.SetInnerNode(node);

result.SetURLElement(node->EnclosingLinkEventParentOrSelf());

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »