client/cmd/isolate/exp_archive.go - Issue 2922153002: Log uses of isolate archive and exparchive when 'chromium' build tag is set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/cmd/isolate/exp_archive.go

Issue 2922153002: Log uses of isolate archive and exparchive when 'chromium' build tag is set.

Patch Set: set upstream Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/cmd/isolate/exp_archive.go

diff --git a/client/cmd/isolate/exp_archive.go b/client/cmd/isolate/exp_archive.go

index d78eb53821d3854fcd24ba3346fa8aacab2f8db4..ae623625053ff44003e4ec8472ecc79896ad508d 100644

--- a/client/cmd/isolate/exp_archive.go

+++ b/client/cmd/isolate/exp_archive.go

@@ -288,7 +288,7 @@ func (c *expArchiveRun) main() error {

MissBytes: &checker.Miss.Bytes,

IsolateHash: []string{string(isolItem.Digest)},

}

- eventlogger := NewLogger(ctx, c.loggingFlags.EventlogEndpoint)

+ eventlogger := NewLogger(ctx, eventlogEndpoint(ctx, c.loggingFlags.EventlogEndpoint, c.isolatedFlags.ServerURL))

op := logpb.IsolateClientEvent_ARCHIVE.Enum()

if err := eventlogger.logStats(ctx, op, start, end, archiveDetails); err != nil {

log.Printf("Failed to log to eventlog: %v", err)