Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 292213002: Change to using nacl_file_info.h from src/public instead. (Closed)

Created:
6 years, 7 months ago by jvoung (off chromium)
Modified:
6 years, 7 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Change to using nacl_file_info.h from src/public instead. Attempting to move the header from src/trusted/validator into src/public: https://codereview.chromium.org/261683002/diff/310001/src/trusted/validator/nacl_file_info.h BUG=https://code.google.com/p/nativeclient/issues/detail?id=3421 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271771

Patch Set 1 #

Patch Set 2 : might as well use helper to check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M components/nacl/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_validation_query.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/file_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung (off chromium)
6 years, 7 months ago (2014-05-20 17:29:05 UTC) #1
Mark Seaborn
LGTM, thanks
6 years, 7 months ago (2014-05-20 17:32:07 UTC) #2
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 7 months ago (2014-05-20 17:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/292213002/20001
6 years, 7 months ago (2014-05-20 17:49:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 21:11:59 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 22:01:40 UTC) #6
Message was sent while issue was closed.
Change committed as 271771

Powered by Google App Engine
This is Rietveld 408576698