Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 292203007: Need to check invalid scheme in navigator content utils (Closed)

Created:
6 years, 7 months ago by gyuyoung-inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Need to check invalid scheme in navigator content utils According to spec, scheme value should not contain a colon. So, this cl checks if scheme contains a colon. "The scheme value, if it contains a colon (as in "mailto:"), will never match anything, since schemes don't contain colons." Spec: http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174748

Patch Set 1 : #

Messages

Total messages: 11 (0 generated)
gyuyoung-inactive
Add kentaro to reviewer.
6 years, 7 months ago (2014-05-23 00:53:11 UTC) #1
gyuyoung-inactive
Add abarth as well.
6 years, 7 months ago (2014-05-23 03:47:39 UTC) #2
haraken
LGTM
6 years, 7 months ago (2014-05-23 07:03:45 UTC) #3
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 7 months ago (2014-05-23 12:15:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/292203007/20001
6 years, 7 months ago (2014-05-23 12:15:30 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 13:46:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 15:09:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8908)
6 years, 7 months ago (2014-05-23 15:09:07 UTC) #8
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 7 months ago (2014-05-24 01:59:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/292203007/20001
6 years, 7 months ago (2014-05-24 02:00:10 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 02:51:58 UTC) #11
Message was sent while issue was closed.
Change committed as 174748

Powered by Google App Engine
This is Rietveld 408576698