Define and implement an interface for on-demand component updates.

Define and implement an interface for on-demand component updates.

This interface consolidates the on-demand functionality and it allows for selective friendship for the callers who are allowed to trigger an on-demand update.

BUG=375315
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271770

[Sorin Jianu, 2014-05-20 16:58:40]

Josh, could you please take a look?

[waffles, 2014-05-20 17:15:19]

lgtm

https://codereview.chromium.org/292203002/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/292203002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/component_updater_service.cc:171: virtual
Status OnDemandUpdate(const std::string& component_id) OVERRIDE;
I don't understand why this should be public, though as discussed it seems safe
to do so, since a reference to a CrxUpdateService is hard to get.

[Sorin Jianu, 2014-05-20 17:39:07]

Sky, please, I need an owner's review for these two files. Thank you!
  chrome\browser\renderer_host\chrome_resource_dispatcher_host_delegate.cc

chrome\browser\ui\webui\components_ui.cc

https://codereview.chromium.org/292203002/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/component_updater_service.cc (right):

https://codereview.chromium.org/292203002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/component_updater_service.cc:171: virtual
Status OnDemandUpdate(const std::string& component_id) OVERRIDE;
On 2014/05/20 17:15:19, waffles wrote:
> I don't understand why this should be public, though as discussed it seems
safe
> to do so, since a reference to a CrxUpdateService is hard to get.

I can make all these members private, since they are only called polymorphically
using a pointer to the instance of the base class.

They are public because it's just idiomatic to have them all declared here and
avoid the clutter of splitting this interface.

[sky, 2014-05-20 17:44:01]

LGTM

[Sorin Jianu, 2014-05-20 17:58:56]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2014-05-20 17:59:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sorin@chromium.org/292203002/1

[commit-bot: I haz the power, 2014-05-20 19:14:48]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 21:53:55]

Change committed as 271770