Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)
Patch Set: changes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index 926391ccad31d22e9129503730e473b2084e3df7..0176fc3559df0bd3bc0af9523539263e5706fb88 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -612,7 +612,10 @@ Network.NetworkLogView = class extends UI.VBox {
selectedNodeNumber++;
selectedTransferSize += requestTransferSize;
}
- if (request.url() === request.networkManager().target().inspectedURL() &&
+ var networkManager = SDK.NetworkManager.managerForRequest(request);
+ // TODO(allada) inspectedURL should be stored in PageLoad used instead of target so HAR requests can have an
+ // inspected url.
+ if (networkManager && request.url() === networkManager.target().inspectedURL() &&
request.resourceType() === Common.resourceTypes.Document)
baseTime = request.startTime;
if (request.endTime > maxTime)

Powered by Google App Engine
This is Rietveld 408576698