Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)
Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
index 12daac355a6bfda4a488dbac8cef388d7b271aba..b80bcd328774425ed2635ef6fed2b9e0ad917927 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -33,7 +33,6 @@
*/
SDK.NetworkRequest = class extends Common.Object {
/**
- * @param {!SDK.NetworkManager} networkManager
* @param {!Protocol.Network.RequestId} requestId
* @param {string} url
* @param {string} documentURL
@@ -41,10 +40,9 @@ SDK.NetworkRequest = class extends Common.Object {
* @param {!Protocol.Network.LoaderId} loaderId
* @param {?Protocol.Network.Initiator} initiator
*/
- constructor(networkManager, requestId, url, documentURL, frameId, loaderId, initiator) {
+ constructor(requestId, url, documentURL, frameId, loaderId, initiator) {
super();
- this._networkManager = networkManager;
this._requestId = requestId;
this.setUrl(url);
this._documentURL = documentURL;
@@ -531,7 +529,8 @@ SDK.NetworkRequest = class extends Common.Object {
} else {
this._path = this._parsedURL.host + this._parsedURL.folderPathComponents;
- var inspectedURL = this._networkManager.target().inspectedURL().asParsedURL();
+ var networkManager = SDK.NetworkManager.forRequest(this);
+ var inspectedURL = networkManager ? networkManager.target().inspectedURL().asParsedURL() : null;
this._path = this._path.trimURL(inspectedURL ? inspectedURL.host : '');
if (this._parsedURL.lastPathComponent || this._parsedURL.queryParams) {
this._name =
@@ -1088,13 +1087,6 @@ SDK.NetworkRequest = class extends Common.Object {
this._eventSourceMessages.push(message);
this.dispatchEventToListeners(SDK.NetworkRequest.Events.EventSourceMessageAdded, message);
}
-
- /**
- * @return {!SDK.NetworkManager}
- */
- networkManager() {
- return this._networkManager;
- }
};
/** @enum {symbol} */

Powered by Google App Engine
This is Rietveld 408576698