third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html - Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)

Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/security/security-secure-but-malicious.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

index be304c96bdb4ff64eeae3e623f08541c393a4f08..f0deac5de99beacda442a3907444ebe5b7638b98 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/security/security-explanation-ordering.html

@@ -33,7 +33,7 @@ function test()

InspectorTest.mainTarget.model(Security.SecurityModel).dispatchEventToListeners(Security.SecurityModel.Events.SecurityStateChanged, new Security.PageSecurityState(Protocol.Security.SecurityState.Secure, true, explanations, insecureContentStatus, null));

- var request = new SDK.NetworkRequest(InspectorTest.mainTarget, 0, "http://foo.test", "https://foo.test", 0, 0, null);

+ var request = new SDK.NetworkRequest(0, "http://foo.test", "https://foo.test", 0, 0, null);

InspectorTest.dispatchRequestFinished(request);

var explanations = Security.SecurityPanel._instance()._mainView.contentElement.getElementsByClassName("security-explanation");