Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)
Patch Set: changes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 var node = request[Network.NetworkLogView._networkNodeSymbol]; 605 var node = request[Network.NetworkLogView._networkNodeSymbol];
606 if (!node) 606 if (!node)
607 continue; 607 continue;
608 nodeCount++; 608 nodeCount++;
609 var requestTransferSize = request.transferSize; 609 var requestTransferSize = request.transferSize;
610 transferSize += requestTransferSize; 610 transferSize += requestTransferSize;
611 if (!node[Network.NetworkLogView._isFilteredOutSymbol]) { 611 if (!node[Network.NetworkLogView._isFilteredOutSymbol]) {
612 selectedNodeNumber++; 612 selectedNodeNumber++;
613 selectedTransferSize += requestTransferSize; 613 selectedTransferSize += requestTransferSize;
614 } 614 }
615 if (request.url() === request.networkManager().target().inspectedURL() && 615 var networkManager = SDK.NetworkManager.managerForRequest(request);
616 // TODO(allada) inspectedURL should be stored in PageLoad used instead of target so HAR requests can have an
617 // inspected url.
618 if (networkManager && request.url() === networkManager.target().inspectedU RL() &&
616 request.resourceType() === Common.resourceTypes.Document) 619 request.resourceType() === Common.resourceTypes.Document)
617 baseTime = request.startTime; 620 baseTime = request.startTime;
618 if (request.endTime > maxTime) 621 if (request.endTime > maxTime)
619 maxTime = request.endTime; 622 maxTime = request.endTime;
620 } 623 }
621 624
622 if (!nodeCount) { 625 if (!nodeCount) {
623 this._showRecordingHint(); 626 this._showRecordingHint();
624 return; 627 return;
625 } 628 }
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 1787
1785 Network.GroupLookupInterface.prototype = { 1788 Network.GroupLookupInterface.prototype = {
1786 /** 1789 /**
1787 * @param {!SDK.NetworkRequest} request 1790 * @param {!SDK.NetworkRequest} request
1788 * @return {?Network.NetworkGroupNode} 1791 * @return {?Network.NetworkGroupNode}
1789 */ 1792 */
1790 groupNodeForRequest: function(request) {}, 1793 groupNodeForRequest: function(request) {},
1791 1794
1792 reset: function() {} 1795 reset: function() {}
1793 }; 1796 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698