[Devtools] Removed NetworkRequest dependency on NetworkManager

third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 409 matching lines @@
     /** @type {number} */
     this.column = column || 0;
     this.parameters = parameters;
     /** @type {!Protocol.Runtime.StackTrace|undefined} */
     this.stackTrace = stackTrace;
     this.timestamp = timestamp || Date.now();
     this.executionContextId = executionContextId || 0;
     this.scriptId = scriptId || null;
     this.workerId = workerId || null;
 
-    var networkManager = (runtimeModel && requestId) ? runtimeModel.target().model(SDK.NetworkManager) : null;
-    this.request = (networkManager && requestId) ? NetworkLog.networkLog.requestForId(networkManager, requestId) : null;
+    var manager = runtimeModel ? runtimeModel.target().model(SDK.NetworkManager) : null;

[dgozman, 2017/06/06 20:54:40]

nit: what was the point of renaming the variable?

[allada, 2017/06/08 00:42:06]

It was just so I could fit the line below on one line.

+    this.request = (manager && requestId) ? NetworkLog.networkLog.requestByManagerAndId(manager, requestId) : null;
 
     if (this.request) {
       var initiator = this.request.initiator();
       if (initiator) {
         this.stackTrace = initiator.stack || undefined;
         if (initiator.url) {
           this.url = initiator.url;
           this.line = initiator.lineNumber || 0;
         }
       }
@@ skipping 220 matching lines @@
     return 2;
   return 3;
 };
 
 ConsoleModel.ConsoleModel._events = Symbol('ConsoleModel.ConsoleModel.events');
 
 /**
  * @type {!ConsoleModel.ConsoleModel}
  */
 ConsoleModel.consoleModel;