Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)
Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Network.NetworkLogViewColumns = class { 7 Network.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!Network.NetworkLogView} networkLogView 9 * @param {!Network.NetworkLogView} networkLogView
10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!Network.NetworkTransferTimeCalculator} timeCalculator
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 var anchor = event.target.enclosingNodeOrSelfWithClass('network-script-initi ated'); 535 var anchor = event.target.enclosingNodeOrSelfWithClass('network-script-initi ated');
536 if (!anchor) 536 if (!anchor)
537 return null; 537 return null;
538 var request = hoveredNode.request(); 538 var request = hoveredNode.request();
539 var initiator = request ? request.initiator() : null; 539 var initiator = request ? request.initiator() : null;
540 if (!initiator || !initiator.stack) 540 if (!initiator || !initiator.stack)
541 return null; 541 return null;
542 return { 542 return {
543 box: anchor.boxInWindow(), 543 box: anchor.boxInWindow(),
544 show: popover => { 544 show: popover => {
545 var manager = anchor.request ? SDK.NetworkManager.forRequest(anchor.requ est) : null;
545 var content = Components.DOMPresentationUtils.buildStackTracePreviewCont ents( 546 var content = Components.DOMPresentationUtils.buildStackTracePreviewCont ents(
546 anchor.request.networkManager().target(), this._popupLinkifier, init iator.stack); 547 manager ? manager.target() : null, this._popupLinkifier, initiator.s tack);
547 popover.contentElement.appendChild(content); 548 popover.contentElement.appendChild(content);
548 return Promise.resolve(true); 549 return Promise.resolve(true);
549 }, 550 },
550 hide: this._popupLinkifier.reset.bind(this._popupLinkifier) 551 hide: this._popupLinkifier.reset.bind(this._popupLinkifier)
551 }; 552 };
552 } 553 }
553 554
554 /** 555 /**
555 * @param {!Array<number>} times 556 * @param {!Array<number>} times
556 * @param {string} className 557 * @param {string} className
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 /** 804 /**
804 * @enum {string} 805 * @enum {string}
805 */ 806 */
806 Network.NetworkLogViewColumns.WaterfallSortIds = { 807 Network.NetworkLogViewColumns.WaterfallSortIds = {
807 StartTime: 'startTime', 808 StartTime: 'startTime',
808 ResponseTime: 'responseReceivedTime', 809 ResponseTime: 'responseReceivedTime',
809 EndTime: 'endTime', 810 EndTime: 'endTime',
810 Duration: 'duration', 811 Duration: 'duration',
811 Latency: 'latency' 812 Latency: 'latency'
812 }; 813 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698