Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2921963002: [Devtools] Removed NetworkRequest dependency on NetworkManager (Closed)
Patch Set: Merge branch 'REMOVE_REDIRECTS_REBASE' into REMOVE_MANAGER_DEPENDENCY Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 var node = request[Network.NetworkLogView._networkNodeSymbol]; 604 var node = request[Network.NetworkLogView._networkNodeSymbol];
605 if (!node) 605 if (!node)
606 continue; 606 continue;
607 nodeCount++; 607 nodeCount++;
608 var requestTransferSize = request.transferSize; 608 var requestTransferSize = request.transferSize;
609 transferSize += requestTransferSize; 609 transferSize += requestTransferSize;
610 if (!node[Network.NetworkLogView._isFilteredOutSymbol]) { 610 if (!node[Network.NetworkLogView._isFilteredOutSymbol]) {
611 selectedNodeNumber++; 611 selectedNodeNumber++;
612 selectedTransferSize += requestTransferSize; 612 selectedTransferSize += requestTransferSize;
613 } 613 }
614 if (request.url() === request.networkManager().target().inspectedURL() && 614 var networkManager = SDK.NetworkManager.forRequest(request);
615 // TODO(allada) inspectedURL should be stored in PageLoad used instead of target so HAR requests can have an
616 // inspected url.
617 if (networkManager && request.url() === networkManager.target().inspectedU RL() &&
615 request.resourceType() === Common.resourceTypes.Document) 618 request.resourceType() === Common.resourceTypes.Document)
616 baseTime = request.startTime; 619 baseTime = request.startTime;
617 if (request.endTime > maxTime) 620 if (request.endTime > maxTime)
618 maxTime = request.endTime; 621 maxTime = request.endTime;
619 } 622 }
620 623
621 if (!nodeCount) { 624 if (!nodeCount) {
622 this._showRecordingHint(); 625 this._showRecordingHint();
623 return; 626 return;
624 } 627 }
(...skipping 1133 matching lines...) Expand 10 before | Expand all | Expand 10 after
1758 1761
1759 Network.GroupLookupInterface.prototype = { 1762 Network.GroupLookupInterface.prototype = {
1760 /** 1763 /**
1761 * @param {!SDK.NetworkRequest} request 1764 * @param {!SDK.NetworkRequest} request
1762 * @return {?Network.NetworkGroupNode} 1765 * @return {?Network.NetworkGroupNode}
1763 */ 1766 */
1764 groupNodeForRequest: function(request) {}, 1767 groupNodeForRequest: function(request) {},
1765 1768
1766 reset: function() {} 1769 reset: function() {}
1767 }; 1770 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698