Only call MirrorsData.retainMetadata* from codegen

pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.mirrors_handler;
 
 import '../common.dart';
 import '../common/resolution.dart';
 import '../compiler.dart';
 import '../constants/values.dart';
@@ skipping 108 matching lines @@
       // necessary, but the backend relies on them being resolved.
       enqueuer.applyImpact(
           _computeImpactForReflectiveStaticFields(_findStaticFieldTargets()));
     }
 
     if (_mirrorsData.mustPreserveNames) _reporter.log('Preserving names.');
 
     if (_mirrorsData.mustRetainMetadata) {
       _reporter.log('Retaining metadata.');
 
-      for (LibraryEntity library in _compiler.libraryLoader.libraries) {
-        _mirrorsData.retainMetadataOfLibrary(library,
-            addForEmission: !enqueuer.isResolutionQueue);
+      /// Register the constant value of [metadata] as live in resolution.
+      void registerMetadataConstant(MetadataAnnotation metadata) {
+        metadata.ensureResolved(_compiler.resolution);
+        ConstantValue constant =
+            _constants.getConstantValueForMetadata(metadata);
+        Dependency dependency =
+            new Dependency(constant, metadata.annotatedElement);
+        _metadataConstants.add(dependency);
+        _impactBuilder.registerConstantUse(new ConstantUse.mirrors(constant));
       }
 
-      if (!enqueuer.queueIsClosed) {
-        /// Register the constant value of [metadata] as live in resolution.
-        void registerMetadataConstant(MetadataAnnotation metadata) {
-          ConstantValue constant =
-              _constants.getConstantValueForMetadata(metadata);
-          Dependency dependency =
-              new Dependency(constant, metadata.annotatedElement);
-          _metadataConstants.add(dependency);
-          _impactBuilder.registerConstantUse(new ConstantUse.mirrors(constant));
-        }
-
-        // TODO(johnniwinther): We should have access to all recently processed
-        // elements and process these instead.
-        processMetadata(enqueuer.processedEntities, registerMetadataConstant);
-      } else {
-        for (Dependency dependency in _metadataConstants) {
-          _impactBuilder.registerConstantUse(
-              new ConstantUse.mirrors(dependency.constant));
-        }
-        _metadataConstants.clear();
-      }
-      enqueuer.applyImpact(_impactBuilder.flush());
+      // TODO(johnniwinther): We should have access to all recently processed
+      // elements and process these instead.
+      processMetadata(enqueuer.processedEntities, registerMetadataConstant);
     }
   }
 
   /// Call [registerMetadataConstant] on all metadata from [entities].
   void processMetadata(
       Iterable<Entity> entities, void onMetadata(MetadataAnnotation metadata)) {
     void processLibraryMetadata(LibraryElement library) {
       if (_registeredMetadata.add(library)) {
         library.metadata.forEach(onMetadata);
         library.entryCompilationUnit.metadata.forEach(onMetadata);
@@ skipping 13 matching lines @@
           }
         }
         if (element.enclosingClass != null) {
           // Only process library of top level fields/methods
           // (and not for classes).
           // TODO(johnniwinther): Fix this: We are missing some metadata on
           // libraries (example: in co19/Language/Metadata/before_export_t01).
           if (element.enclosingElement is ClassElement) {
             // Use [enclosingElement] instead of [enclosingClass] to ensure that
             // we process patch class metadata for patch and injected members.
-            processElementMetadata(element.enclosingElement);
           }
-        } else {
-          processLibraryMetadata(element.library);
+          processElementMetadata(element.enclosingClass);
         }
+        processLibraryMetadata(element.library);
       }
     }
 
     entities.forEach((MemberElement member) => processElementMetadata(member));
   }
 
   void onResolutionComplete() {
     _registeredMetadata.clear();
   }
 
@@ skipping 275 matching lines @@
 
 /// Records that [constant] is used by the element behind [registry].
 class Dependency {
   final ConstantValue constant;
   final Element annotatedElement;
 
   const Dependency(this.constant, this.annotatedElement);
 
   String toString() => '$annotatedElement:${constant.toStructuredText()}';
 }