Chromium Code Reviews| Index: ios/clean/chrome/browser/ui/overlays/overlay_queue_unittest.mm |
| diff --git a/ios/clean/chrome/browser/ui/overlays/overlay_queue_unittest.mm b/ios/clean/chrome/browser/ui/overlays/overlay_queue_unittest.mm |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..df668c387c0a25d704d0dbbbdf36387a5138ca46 |
| --- /dev/null |
| +++ b/ios/clean/chrome/browser/ui/overlays/overlay_queue_unittest.mm |
| @@ -0,0 +1,131 @@ |
| +// Copyright 2017 The Chromium Authors. All rights reserved. |
| +// Use of this source code is governed by a BSD-style license that can be |
| +// found in the LICENSE file. |
| + |
| +#import "ios/clean/chrome/browser/ui/overlays/overlay_queue.h" |
| + |
| +#import "base/mac/scoped_nsobject.h" |
| +#include "base/memory/ptr_util.h" |
| +#import "ios/clean/chrome/browser/ui/overlays/overlay_queue_observer.h" |
| +#import "ios/web/public/test/fakes/test_web_state.h" |
| +#include "testing/gtest/include/gtest/gtest.h" |
| +#include "testing/gtest_mac.h" |
| +#include "testing/platform_test.h" |
| + |
| +#if !defined(__has_feature) || !__has_feature(objc_arc) |
| +#error "This file requires ARC support." |
| +#endif |
| + |
| +// Test OverlayQueue implementation. Subclass-specific functionality will be |
| +// tested in other files. |
| +class TestOverlayQueue : public OverlayQueue { |
| + public: |
| + void StartNextOverlay() override { OverlayWasStarted(); } |
| + void AddOverlay(BrowserCoordinator* overlay) { |
| + OverlayQueue::AddOverlay(overlay); |
| + } |
| +}; |
| + |
| +// Test BrowserCoordinator. |
| +@interface TestBrowserCoordinator : BrowserCoordinator |
| +@property(nonatomic, readonly) BOOL cancelled; |
| +@end |
| + |
| +@implementation TestBrowserCoordinator |
| +@synthesize cancelled = _cancelled; |
| +- (void)cancelOverlay { |
| + _cancelled = YES; |
| +} |
| +@end |
| + |
| +// Test OverlayQueueObserver. |
| +class TestOverlayQueueObserver : public OverlayQueueObserver { |
| + public: |
| + TestOverlayQueueObserver() |
| + : did_add_called_(false), |
| + will_replace_called_(false), |
| + stop_visible_called_(false), |
| + did_cancel_called_(false) {} |
| + |
| + void OverlayQueueDidAddOverlay(OverlayQueue* queue) override { |
| + did_add_called_ = true; |
| + } |
| + void OverlayQueueWillReplaceVisibleOverlay(OverlayQueue* queue) override { |
| + will_replace_called_ = true; |
| + } |
| + void OverlayQueueDidStopVisibleOverlay(OverlayQueue* queue) override { |
| + stop_visible_called_ = true; |
| + } |
| + void OverlayQueueDidCancelOverlays(OverlayQueue* queue) override { |
| + did_cancel_called_ = true; |
| + } |
| + |
| + bool did_add_called() { return did_add_called_; } |
| + bool will_replace_called() { return will_replace_called_; } |
| + bool stop_visible_called() { return stop_visible_called_; } |
| + bool did_cancel_called() { return did_cancel_called_; } |
| + |
| + private: |
| + bool did_add_called_; |
| + bool will_replace_called_; |
| + bool stop_visible_called_; |
| + bool did_cancel_called_; |
| +}; |
| + |
| +class OverlayQueueTest : public PlatformTest { |
| + public: |
| + OverlayQueueTest() : PlatformTest() { queue_.AddObserver(&observer_); } |
| + |
| + TestOverlayQueue& queue() { return queue_; } |
| + TestOverlayQueueObserver& observer() { return observer_; } |
| + |
| + private: |
| + TestOverlayQueue queue_; |
| + TestOverlayQueueObserver observer_; |
| +}; |
| + |
| +// Tests that adding an overlay to the queue updates state accordingly and |
| +// notifies observers. |
| +TEST_F(OverlayQueueTest, AddOverlay) { |
| + BrowserCoordinator* overlay = |
| + [[BrowserCoordinator alloc] initWithQueue:&queue()]; |
| + queue().AddOverlay(overlay); |
| + EXPECT_TRUE(queue().HasQueuedOverlays()); |
| + EXPECT_FALSE(queue().IsShowingOverlay()); |
| + EXPECT_TRUE(observer().did_add_called()); |
| +} |
| + |
| +// Tests that OverlayWasStopped() updates state properly. |
| +TEST_F(OverlayQueueTest, OverlayWasStopped) { |
| + BrowserCoordinator* overlay = |
| + [[BrowserCoordinator alloc] initWithQueue:&queue()]; |
| + queue().AddOverlay(overlay); |
| + queue().StartNextOverlay(); |
| + queue().OverlayWasStopped(overlay); |
| + EXPECT_FALSE(queue().HasQueuedOverlays()); |
| + EXPECT_FALSE(queue().IsShowingOverlay()); |
| + EXPECT_TRUE(observer().stop_visible_called()); |
| +} |
| + |
| +// |
|
marq (ping after 24h)
2017/06/21 09:41:53
Missing comment?
kkhorimoto
2017/06/23 06:11:16
Whoops, yes. This test is fixed now!
|
| +TEST_F(OverlayQueueTest, ReplaceOverlay) { |
| + BrowserCoordinator* overlay = |
| + [[BrowserCoordinator alloc] initWithQueue:&queue()]; |
| + queue().AddOverlay(overlay); |
|
marq (ping after 24h)
2017/06/21 09:41:53
Missing test expectations?
kkhorimoto
2017/06/23 06:11:16
Added!
|
| +} |
| + |
| +// Tests that CancelOverlays() cancels all queued overlays for a WebState. |
| +TEST_F(OverlayQueueTest, CancelOverlays) { |
| + TestBrowserCoordinator* overlay0 = |
| + [[TestBrowserCoordinator alloc] initWithQueue:&queue()]; |
| + TestBrowserCoordinator* overlay1 = |
| + [[TestBrowserCoordinator alloc] initWithQueue:&queue()]; |
| + queue().AddOverlay(overlay0); |
| + queue().AddOverlay(overlay1); |
| + queue().CancelOverlays(); |
| + EXPECT_FALSE(queue().HasQueuedOverlays()); |
| + EXPECT_FALSE(queue().IsShowingOverlay()); |
| + EXPECT_TRUE(observer().did_cancel_called()); |
| + EXPECT_TRUE(overlay0.cancelled); |
| + EXPECT_TRUE(overlay1.cancelled); |
| +} |