media/filters/gpu_video_decoder.cc - Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: out-of-line DefaultDeleter::operator() Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index 92c2561457d0d3a16ba145ddd23f7477634c1e16..1d26d012b97eacd1461600d52ded1d65db44bbea 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -212,8 +212,7 @@ void GpuVideoDecoder::DestroyPictureBuffers(PictureBufferMap* buffers) {

void GpuVideoDecoder::DestroyVDA() {

DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent();

- if (vda_)

- vda_.release()->Destroy();

+ vda_.reset();

// Not destroying PictureBuffers in |picture_buffers_at_display_| yet, since

// their textures may still be in use by the user of this GpuVideoDecoder.