content/renderer/media/rtc_video_encoder.cc - Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_encoder.cc

Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: out-of-line DefaultDeleter::operator() Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/rtc_video_encoder.cc

diff --git a/content/renderer/media/rtc_video_encoder.cc b/content/renderer/media/rtc_video_encoder.cc

index e078b7ea735c178094e110472cd7456c234e4f77..22f17a178367b1cf923a14b9747a40f99d5e4d46 100644

--- a/content/renderer/media/rtc_video_encoder.cc

+++ b/content/renderer/media/rtc_video_encoder.cc

@@ -279,8 +279,7 @@ void RTCVideoEncoder::Impl::RequestEncodingParametersChange(uint32 bitrate,

void RTCVideoEncoder::Impl::Destroy() {

DVLOG(3) << "Impl::Destroy()";

DCHECK(thread_checker_.CalledOnValidThread());

- if (video_encoder_)

- video_encoder_.release()->Destroy();

+ video_encoder_.reset();

}

void RTCVideoEncoder::Impl::RequireBitstreamBuffers(

@@ -400,8 +399,7 @@ void RTCVideoEncoder::Impl::NotifyError(

retval = WEBRTC_VIDEO_CODEC_ERROR;

}

- if (video_encoder_)

- video_encoder_.release()->Destroy();

+ video_encoder_.reset();

if (async_waiter_) {

SignalAsyncWaiter(retval);