media/filters/gpu_video_decoder.cc - Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile for Impl Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index 92c2561457d0d3a16ba145ddd23f7477634c1e16..a0b7a7f0bc85c2a7ee4f4a5953a9924beed7dae1 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -212,8 +212,7 @@ void GpuVideoDecoder::DestroyPictureBuffers(PictureBufferMap* buffers) {

void GpuVideoDecoder::DestroyVDA() {

DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent();

- if (vda_)

- vda_.release()->Destroy();

+ vda_.reset(NULL);

Ami GONE FROM CHROMIUM 2014/05/27 20:06:02 s/NULL// ?

dmichael (off chromium) 2014/05/28 22:31:25 Oh, right, thanks. Done here and elsewhere.

// Not destroying PictureBuffers in |picture_buffers_at_display_| yet, since

// their textures may still be in use by the user of this GpuVideoDecoder.