Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: content/common/gpu/media/video_decode_accelerator_impl.h

Issue 292183011: Make DefaultDeleter for Video{De|En}codeAccelerator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: out-of-line DefaultDeleter::operator() Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_COMMON_GPU_MEDIA_VIDEO_DECODE_ACCELERATOR_IMPL_H_ 5 #ifndef CONTENT_COMMON_GPU_MEDIA_VIDEO_DECODE_ACCELERATOR_IMPL_H_
6 #define CONTENT_COMMON_GPU_MEDIA_VIDEO_DECODE_ACCELERATOR_IMPL_H_ 6 #define CONTENT_COMMON_GPU_MEDIA_VIDEO_DECODE_ACCELERATOR_IMPL_H_
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 #include "media/video/video_decode_accelerator.h" 9 #include "media/video/video_decode_accelerator.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 class CONTENT_EXPORT VideoDecodeAcceleratorImpl 13 class CONTENT_EXPORT VideoDecodeAcceleratorImpl
14 : public media::VideoDecodeAccelerator { 14 : public media::VideoDecodeAccelerator {
15 public: 15 public:
16 VideoDecodeAcceleratorImpl(); 16 VideoDecodeAcceleratorImpl();
17 virtual ~VideoDecodeAcceleratorImpl();
18 17
19 // Returns true if VDA::Decode and VDA::Client callbacks can run on the IO 18 // Returns true if VDA::Decode and VDA::Client callbacks can run on the IO
20 // thread. Otherwise they will run on the GPU child thread. The purpose of 19 // thread. Otherwise they will run on the GPU child thread. The purpose of
21 // running Decode on the IO thread is to reduce decode latency. Note Decode 20 // running Decode on the IO thread is to reduce decode latency. Note Decode
22 // should return as soon as possible and not block on the IO thread. Also, 21 // should return as soon as possible and not block on the IO thread. Also,
23 // PictureReady should be run on the child thread if a picture is delivered 22 // PictureReady should be run on the child thread if a picture is delivered
24 // the first time so it can be cleared. 23 // the first time so it can be cleared.
25 virtual bool CanDecodeOnIOThread(); 24 virtual bool CanDecodeOnIOThread();
25
26 protected:
27 virtual ~VideoDecodeAcceleratorImpl();
26 }; 28 };
27 29
28 } // namespace content 30 } // namespace content
29 31
32 namespace base {
33
34 template <class T>
35 struct DefaultDeleter;
36
37 // Specialize DefaultDeleter so that scoped_ptr<VideoDecodeAcceleratorImpl>
38 // always uses "Destroy()" instead of trying to use the destructor.
39 template <>
40 struct DefaultDeleter<content::VideoDecodeAcceleratorImpl> {
41 public:
42 inline void operator()(void* video_decode_accelerator) const {
43 static_cast<content::VideoDecodeAcceleratorImpl*>(video_decode_accelerator)
44 ->Destroy();
45 }
46 };
47
48 } // namespace base
49
30 #endif // CONTENT_COMMON_GPU_MEDIA_VIDEO_DECODE_ACCELERATOR_IMPL_H_ 50 #endif // CONTENT_COMMON_GPU_MEDIA_VIDEO_DECODE_ACCELERATOR_IMPL_H_
OLDNEW
« no previous file with comments | « content/common/gpu/media/gpu_video_encode_accelerator.cc ('k') | content/common/gpu/media/video_decode_accelerator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698