Use special icon for shared folders in the directory tree.

Use special icon for shared folders in the directory tree.

- Pass the reference to the metadata cache to the Directory Tree.
- When a tree item needs redraw, check the metadata and toggle css class 'shared'.

BUG=264812
TEST=manually confirmed

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272227

[fukino, 2014-05-21 06:15:47]

@yoshiki, PTAL!

[yoshiki, 2014-05-21 17:20:31]

sorry for late

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_tree.js:333: 
Please write JSdoc.

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_tree.js:334:
DirectoryItem.prototype.redraw = function() {
Please use more concrete name. (eg. setSharedFolderIconIfNessesary or
updateSharedStatusIcon)

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_tree.js:340:
function(metadata) {
'matadata' can be null in case of failure. Please handle such a case.

[fukino, 2014-05-22 03:15:53]

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_tree.js:333: 
On 2014/05/21 17:20:31, yoshiki wrote:
> Please write JSdoc.

Oops! Sorry for missing document. Done.

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_tree.js:334:
DirectoryItem.prototype.redraw = function() {
On 2014/05/21 17:20:31, yoshiki wrote:
> Please use more concrete name. (eg. setSharedFolderIconIfNessesary or
> updateSharedStatusIcon) 

Thanks for suggested names. I pick up updateSharedStatusIcon. Done.

https://codereview.chromium.org/292183005/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/directory_tree.js:340:
function(metadata) {
On 2014/05/21 17:20:31, yoshiki wrote:
> 'matadata' can be null in case of failure. Please handle such a case.

Done.

[yoshiki, 2014-05-22 05:41:37]

https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_tree.js:39:
currentElement.updateSharedStatusIcon();
I think updateSharedStatusIcon is not called at the time of item creation. Isn't
it necessary to call that at l.36 as well?

[fukino, 2014-05-22 06:35:25]

https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_tree.js:39:
currentElement.updateSharedStatusIcon();
On 2014/05/22 05:41:38, yoshiki wrote:
> I think updateSharedStatusIcon is not called at the time of item creation.
Isn't
> it necessary to call that at l.36 as well?

Thank you for pointing it out!
I misunderstood the process to update the subtree...

Because the updateSharedStatusIcon() should be always called when the tree item
is created, I place the updateSharedStatusIcon() into the decorate function.
What do you think?

[yoshiki, 2014-05-22 06:39:41]

https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):

https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/directory_tree.js:39:
currentElement.updateSharedStatusIcon();
On 2014/05/22 06:35:25, fukino wrote:
> On 2014/05/22 05:41:38, yoshiki wrote:
> > I think updateSharedStatusIcon is not called at the time of item creation.
> Isn't
> > it necessary to call that at l.36 as well?
> 
> Thank you for pointing it out!
> I misunderstood the process to update the subtree...
> 
> Because the updateSharedStatusIcon() should be always called when the tree
item
> is created, I place the updateSharedStatusIcon() into the decorate function.
> What do you think?

If so, the icon is not reflected the latest 'share' status when the status is
changed after creation. Is it ok?

[fukino, 2014-05-22 06:51:22]

On 2014/05/22 06:39:41, yoshiki wrote:
>
https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):
> 
>
https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/directory_tree.js:39:
> currentElement.updateSharedStatusIcon();
> On 2014/05/22 06:35:25, fukino wrote:
> > On 2014/05/22 05:41:38, yoshiki wrote:
> > > I think updateSharedStatusIcon is not called at the time of item creation.
> > Isn't
> > > it necessary to call that at l.36 as well?
> > 
> > Thank you for pointing it out!
> > I misunderstood the process to update the subtree...
> > 
> > Because the updateSharedStatusIcon() should be always called when the tree
> item
> > is created, I place the updateSharedStatusIcon() into the decorate function.
> > What do you think?
> 
> If so, the icon is not reflected the latest 'share' status when the status is
> changed after creation. Is it ok?

Oh, sorry for confusing explanation!
In Patch Set 3, I call the updateSharedStatusIcon() in decorate() *in addition
to* the previous position (in updateSubElementsFromList(), for the case that
only properties are changed).

[yoshiki, 2014-05-22 09:09:55]

On 2014/05/22 06:51:22, fukino wrote:
> On 2014/05/22 06:39:41, yoshiki wrote:
> >
>
https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
> > File ui/file_manager/file_manager/foreground/js/directory_tree.js (right):
> > 
> >
>
https://codereview.chromium.org/292183005/diff/20001/ui/file_manager/file_man...
> > ui/file_manager/file_manager/foreground/js/directory_tree.js:39:
> > currentElement.updateSharedStatusIcon();
> > On 2014/05/22 06:35:25, fukino wrote:
> > > On 2014/05/22 05:41:38, yoshiki wrote:
> > > > I think updateSharedStatusIcon is not called at the time of item
creation.
> > > Isn't
> > > > it necessary to call that at l.36 as well?
> > > 
> > > Thank you for pointing it out!
> > > I misunderstood the process to update the subtree...
> > > 
> > > Because the updateSharedStatusIcon() should be always called when the tree
> > item
> > > is created, I place the updateSharedStatusIcon() into the decorate
function.
> > > What do you think?
> > 
> > If so, the icon is not reflected the latest 'share' status when the status
is
> > changed after creation. Is it ok?
> 
> Oh, sorry for confusing explanation!
> In Patch Set 3, I call the updateSharedStatusIcon() in decorate() *in addition
> to* the previous position (in updateSubElementsFromList(), for the case that
> only properties are changed).

Got it. LGTM

[fukino, 2014-05-22 09:14:37]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-05-22 09:15:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/292183005/40001

[commit-bot: I haz the power, 2014-05-22 17:52:11]

Change committed as 272227