chrome/browser/resources/print_preview/settings/other_options_settings.js - Issue 2921783003: WebUI: Fix/suppress some existing violations of no-restricted-globals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/other_options_settings.js

Issue 2921783003: WebUI: Fix/suppress some existing violations of no-restricted-globals. (Closed)

Patch Set: Address comment. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/.eslintrc.js ('K') | « chrome/browser/resources/print_preview/print_preview_animations.js ('k') | ui/webui/resources/js/cr.js » ('j') | ui/webui/resources/js/util.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/other_options_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/other_options_settings.js b/chrome/browser/resources/print_preview/settings/other_options_settings.js

index 35cfeff8a8a420eb7f819c65516a09f68553700c..7b571279d3f26d9d5a169bd42babc000ff4a1f0d 100644

--- a/chrome/browser/resources/print_preview/settings/other_options_settings.js

+++ b/chrome/browser/resources/print_preview/settings/other_options_settings.js

@@ -69,8 +69,7 @@ cr.define('print_preview', function() {

/** Initializes container and checkbox */

decorate: function() {

- this.container_ = /** @type {HTMLElement} */(

- document.getElementById(this.cssId_));

+ this.container_ = $(this.cssId_);

this.checkbox_ = /** @type {HTMLElement} */(

this.container_.querySelector('.checkbox'));