chrome/browser/resources/extensions/extension_command_list.js - Issue 2921783003: WebUI: Fix/suppress some existing violations of no-restricted-globals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_command_list.js

Issue 2921783003: WebUI: Fix/suppress some existing violations of no-restricted-globals. (Closed)

Patch Set: Address comment. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/extension_command_list.js

diff --git a/chrome/browser/resources/extensions/extension_command_list.js b/chrome/browser/resources/extensions/extension_command_list.js

index eca1797c75babb20359c27eed7ca1ea225ca5e77..3d6572a772e07c01cb647f25d72ccc2880fad17c 100644

--- a/chrome/browser/resources/extensions/extension_command_list.js

+++ b/chrome/browser/resources/extensions/extension_command_list.js

@@ -378,7 +378,7 @@ cr.define('extensions', function() {

handleSetCommandScope_: function(event) {

var parsed = this.parseElementId_('setCommandScope', event.target.id);

- var element = document.getElementById(

+ var element = $(

'setCommandScope-' + parsed.extensionId + '-' + parsed.commandName);

var scope = element.selectedIndex == 1 ?

chrome.developerPrivate.CommandScope.GLOBAL :