Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: ui/webui/resources/js/util.js

Issue 2921783003: WebUI: Fix/suppress some existing violations of no-restricted-globals. (Closed)
Patch Set: Fix svg Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/cr.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/util.js
diff --git a/ui/webui/resources/js/util.js b/ui/webui/resources/js/util.js
index 8d73dc60ac7e1518e97546ad1ceca77f11ac0011..2b8cef58cff02947ac055a90b79eb8a948b367c5 100644
--- a/ui/webui/resources/js/util.js
+++ b/ui/webui/resources/js/util.js
@@ -10,6 +10,9 @@
* @return {HTMLElement} The found element or null if not found.
*/
function $(id) {
+ // Disable getElementById restriction here, since we are instructing other
+ // places to re-use the $() that is defined here.
+ // eslint-disable-next-line no-restricted-properties
var el = document.getElementById(id);
return el ? assertInstanceof(el, HTMLElement) : null;
}
@@ -22,6 +25,9 @@ function $(id) {
* @return {Element} The found element or null if not found.
*/
function getSVGElement(id) {
+ // Disable getElementById restriction here, since it is not suitable for SVG
+ // elements.
+ // eslint-disable-next-line no-restricted-properties
var el = document.getElementById(id);
return el ? assertInstanceof(el, Element) : null;
}
« no previous file with comments | « ui/webui/resources/js/cr.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698