Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(723)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/resources/chromeos/chromevox/.eslintrc.js
Issue
2921783003
:
WebUI: Fix/suppress some existing violations of no-restricted-globals. (Closed)
Patch Set: Fix svg
Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/resources/chromeos/chromevox/.eslintrc.js
chrome/browser/resources/chromeos/keyboard/keyboard_utils.js
chrome/browser/resources/chromeos/select_to_speak/.eslintrc.js
chrome/browser/resources/chromeos/switch_access/options.js
chrome/browser/resources/hotword/audio_client.js
chrome/browser/resources/instant/instant.js
chrome/browser/resources/print_preview/print_preview_animations.js
chrome/browser/resources/print_preview/settings/other_options_settings.js
ui/webui/resources/js/cr.js
ui/webui/resources/js/util.js
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
chrome/browser/resources/chromeos/keyboard/keyboard_utils.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2017 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
module.exports = {
6
'env': {
7
'browser': true,
8
'es6': true
9
},
10
'rules': {
11
// Override restrictions for document.getElementById usage since,
12
// chrome://resources/js/util.js is not accessible for chromevox.
13
'no-restricted-properties': 'off',
14
},
15
};
OLD
NEW
« no previous file with comments
|
« no previous file
|
chrome/browser/resources/chromeos/keyboard/keyboard_utils.js »
('j') |
no next file with comments »
Issue 2921783003: WebUI: Fix/suppress some existing violations of no-restricted-globals. (Closed)
Created 3 years, 6 months ago by dpapad
Modified 3 years, 6 months ago
Reviewers: Dan Beam
Base URL:
Comments: 7
This is Rietveld
408576698
Chromium Code Reviews
Issue 2921783003:
WebUI: Fix/suppress some existing violations of no-restricted-globals. (Closed)
